[PATCH net] flow_offload: return EOPNOTSUPP for the unsupported mpls action type

* [PATCH net] flow_offload: return EOPNOTSUPP for the unsupported mpls action type
@ 2021-12-13 14:46 Simon Horman
  2021-12-14 12:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2021-12-13 14:46 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski
  Cc: Jamal Hadi Salim, Cong Wang, Jiri Pirko, netdev, oss-drivers,
	Roi Dayan, Baowen Zheng, Simon Horman

From: Baowen Zheng <baowen.zheng@corigine.com>

We need to return EOPNOTSUPP for the unsupported mpls action type when
setup the flow action.

In the original implement, we will return 0 for the unsupported mpls
action type, actually we do not setup it and the following actions
to the flow action entry.

Fixes: 9838b20a7fb2 ("net: sched: take rtnl lock in tc_setup_flow_action()")
Signed-off-by: Baowen Zheng <baowen.zheng@corigine.com>
Signed-off-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 net/sched/cls_api.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 2ef8f5a6205a..e54f0a42270c 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -3687,6 +3687,7 @@ int tc_setup_flow_action(struct flow_action *flow_action,
 				entry->mpls_mangle.ttl = tcf_mpls_ttl(act);
 				break;
 			default:
+				err = -EOPNOTSUPP;
 				goto err_out_locked;
 			}
 		} else if (is_tcf_skbedit_ptype(act)) {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread