[PATCH] inet: missing lock releases in udp.c

* [PATCH] inet: missing lock releases in udp.c
@ 2022-01-21  3:15 ycaibb
  2022-01-23  7:11 ` [inet] 1b84613d30: WARNING:at_kernel/softirq.c:#__local_bh_enable_ip kernel test robot
  2022-01-23 19:57 ` [PATCH] inet: missing lock releases in udp.c Cong Wang
  0 siblings, 2 replies; 3+ messages in thread
From: ycaibb @ 2022-01-21  3:15 UTC (permalink / raw)
  To: davem, yoshfuji, dsahern, kuba, ast, daniel, andrii, kafai,
	songliubraving, yhs, john.fastabend, kpsingh
  Cc: netdev, ycaibb, linux-kernel, bpf

From: Ryan Cai <ycaibb@gmail.com>

In method udp_get_first, the lock hslot->lock is not released when afinfo->family == AF_UNSPEC || sk->sk_family == afinfo->family is true. This patch fixes the problem by adding the unlock statement.

Signed-off-by: Ryan Cai <ycaibb@gmail.com>
---
 net/ipv4/udp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 23b05e28490b..f7d573ecaafb 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -2967,6 +2967,7 @@ static struct sock *udp_get_first(struct seq_file *seq, int start)
 				continue;
 			if (afinfo->family == AF_UNSPEC ||
 			    sk->sk_family == afinfo->family)
+				spin_unlock_bh(&hslot->lock);
 				goto found;
 		}
 		spin_unlock_bh(&hslot->lock);
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread