* [PATCH v2] net: ethernet: cortina: permit to set mac address in DT
@ 2022-01-25 21:08 Corentin Labbe
2022-01-27 2:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2022-01-25 21:08 UTC (permalink / raw)
To: davem, kuba, linus.walleij, ulli.kroll
Cc: linux-arm-kernel, linux-kernel, netdev, Corentin Labbe
Add ability of setting mac address in DT for cortina ethernet driver.
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes since v1:
- fixed reverse christmas tree of the mac variable
drivers/net/ethernet/cortina/gemini.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
index c78b99a497df..8014eb33937c 100644
--- a/drivers/net/ethernet/cortina/gemini.c
+++ b/drivers/net/ethernet/cortina/gemini.c
@@ -2363,11 +2363,13 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port)
static int gemini_ethernet_port_probe(struct platform_device *pdev)
{
char *port_names[2] = { "ethernet0", "ethernet1" };
+ struct device_node *np = pdev->dev.of_node;
struct gemini_ethernet_port *port;
struct device *dev = &pdev->dev;
struct gemini_ethernet *geth;
struct net_device *netdev;
struct device *parent;
+ u8 mac[ETH_ALEN];
unsigned int id;
int irq;
int ret;
@@ -2473,6 +2475,12 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
netif_napi_add(netdev, &port->napi, gmac_napi_poll,
DEFAULT_NAPI_WEIGHT);
+ ret = of_get_mac_address(np, mac);
+ if (!ret) {
+ dev_info(dev, "Setting macaddr from DT %pM\n", mac);
+ memcpy(port->mac_addr, mac, ETH_ALEN);
+ }
+
if (is_valid_ether_addr((void *)port->mac_addr)) {
eth_hw_addr_set(netdev, (u8 *)port->mac_addr);
} else {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: ethernet: cortina: permit to set mac address in DT
2022-01-25 21:08 [PATCH v2] net: ethernet: cortina: permit to set mac address in DT Corentin Labbe
@ 2022-01-27 2:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-27 2:50 UTC (permalink / raw)
To: Corentin Labbe
Cc: davem, kuba, linus.walleij, ulli.kroll, linux-arm-kernel,
linux-kernel, netdev
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 25 Jan 2022 21:08:11 +0000 you wrote:
> Add ability of setting mac address in DT for cortina ethernet driver.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Changes since v1:
> - fixed reverse christmas tree of the mac variable
>
> [...]
Here is the summary with links:
- [v2] net: ethernet: cortina: permit to set mac address in DT
https://git.kernel.org/netdev/net-next/c/15f75fd31932
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-27 2:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 21:08 [PATCH v2] net: ethernet: cortina: permit to set mac address in DT Corentin Labbe
2022-01-27 2:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).