From: "Pali Rohár" <pali@kernel.org>
To: Jerome Pouiller <Jerome.Pouiller@silabs.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Kalle Valo <kvalo@codeaurora.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/2] staging: wfx: WF200 has no official SDIO IDs
Date: Wed, 16 Feb 2022 10:50:59 +0100 [thread overview]
Message-ID: <20220216095059.how2bexndwenhs6h@pali> (raw)
In-Reply-To: <20220216093112.92469-2-Jerome.Pouiller@silabs.com>
On Wednesday 16 February 2022 10:31:11 Jerome Pouiller wrote:
> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Some may think that SDIO_VENDOR_ID_SILABS / SDIO_DEVICE_ID_SILABS_WF200
> are official SDIO IDs. However, it is not the case, the values used by
> WF200 are not official (BTW, the driver rely on the DT rather than on
> the SDIO IDs to probe the device).
>
> To avoid any confusion, remove the definitions SDIO_*_ID_SILABS* and use
> raw values.
>
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Reviewed-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/staging/wfx/bus_sdio.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c
> index bc3df85a05b6..312d2d391a24 100644
> --- a/drivers/staging/wfx/bus_sdio.c
> +++ b/drivers/staging/wfx/bus_sdio.c
> @@ -257,10 +257,9 @@ static void wfx_sdio_remove(struct sdio_func *func)
> sdio_release_host(func);
> }
>
> -#define SDIO_VENDOR_ID_SILABS 0x0000
> -#define SDIO_DEVICE_ID_SILABS_WF200 0x1000
> static const struct sdio_device_id wfx_sdio_ids[] = {
> - { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) },
> + /* WF200 does not have official VID/PID */
> + { SDIO_DEVICE(0x0000, 0x1000) },
> { },
> };
> MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids);
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-02-16 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 9:31 [PATCH 0/2] staging: wfx: apply SDIO suggestions Jerome Pouiller
2022-02-16 9:31 ` [PATCH 1/2] staging: wfx: WF200 has no official SDIO IDs Jerome Pouiller
2022-02-16 9:50 ` Pali Rohár [this message]
2022-02-16 9:31 ` [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200 Jerome Pouiller
2022-02-16 9:51 ` Pali Rohár
2022-02-17 9:59 ` Kalle Valo
2022-02-17 14:54 ` Ulf Hansson
2022-02-17 15:04 ` Kalle Valo
2022-02-17 15:41 ` Jérôme Pouiller
2022-02-17 15:58 ` Greg Kroah-Hartman
2022-02-16 10:35 ` [PATCH 0/2] staging: wfx: apply SDIO suggestions Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216095059.how2bexndwenhs6h@pali \
--to=pali@kernel.org \
--cc=Jerome.Pouiller@silabs.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).