From: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
linux-mmc@vger.kernel.org, "Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200
Date: Thu, 17 Feb 2022 16:41:38 +0100 [thread overview]
Message-ID: <2063576.g1lFC2ckuq@pc-42> (raw)
In-Reply-To: <87ley9zg8c.fsf@kernel.org>
On Thursday 17 February 2022 16:04:51 CET Kalle Valo wrote:
> Ulf Hansson <ulf.hansson@linaro.org> writes:
> > On Thu, 17 Feb 2022 at 10:59, Kalle Valo <kvalo@kernel.org> wrote:
> >> Jerome Pouiller <Jerome.Pouiller@silabs.com> writes:
> >> > From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> >> >
> >> > Until now, the SDIO quirks are applied directly from the driver.
> >> > However, it is better to apply the quirks before driver probing. So,
> >> > this patch relocate the quirks in the MMC framework.
> >>
> >> It would be good to know how this is better, what's the concrete
> >> advantage?
> >
> > The mmc core has a quirk interface for all types of cards
> > (eMMC/SD/SDIO), which thus keeps these things from sprinkling to
> > drivers. In some cases, the quirk needs to be applied already during
> > card initialization, which is earlier than when probing an SDIO func
> > driver or the MMC block device driver.
> >
> > Perhaps it's a good idea to explain a bit about this in the commit message.
>
> I would add the whole paragraph to the commit log :)
Arf, Greg has just pulled this patch into staging-testing. I assume it is
too late to change the commit message.
--
Jérôme Pouiller
next prev parent reply other threads:[~2022-02-17 15:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 9:31 [PATCH 0/2] staging: wfx: apply SDIO suggestions Jerome Pouiller
2022-02-16 9:31 ` [PATCH 1/2] staging: wfx: WF200 has no official SDIO IDs Jerome Pouiller
2022-02-16 9:50 ` Pali Rohár
2022-02-16 9:31 ` [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200 Jerome Pouiller
2022-02-16 9:51 ` Pali Rohár
2022-02-17 9:59 ` Kalle Valo
2022-02-17 14:54 ` Ulf Hansson
2022-02-17 15:04 ` Kalle Valo
2022-02-17 15:41 ` Jérôme Pouiller [this message]
2022-02-17 15:58 ` Greg Kroah-Hartman
2022-02-16 10:35 ` [PATCH 0/2] staging: wfx: apply SDIO suggestions Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2063576.g1lFC2ckuq@pc-42 \
--to=jerome.pouiller@silabs.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).