[PATCH net-next 0/1] modify PBL values in snps,dwmac.yaml

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH net-next 0/1] modify PBL values in snps,dwmac.yaml
@ 2022-03-24  1:21 Biao Huang
  2022-03-24  1:21 ` [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL Biao Huang
  0 siblings, 1 reply; 5+ messages in thread
From: Biao Huang @ 2022-03-24  1:21 UTC (permalink / raw)
  To: davem, Jakub Kicinski, Rob Herring
  Cc: Matthias Brugger, Giuseppe Cavallaro, Alexandre Torgue,
	Jose Abreu, Biao Huang, netdev, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, srv_heupstream, macpaul.lin

This patch should be applied befor the series:
    "[PATCH net-next v13 0/7] MediaTek Ethernet Patches on MT8195"
to avoid dtbo build failings.

@Rob, please review it, thanks very much.

Biao Huang (1):
  dt-bindings: net: snps,dwmac: modify available values of PBL

 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.25.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL
  2022-03-24  1:21 [PATCH net-next 0/1] modify PBL values in snps,dwmac.yaml Biao Huang
@ 2022-03-24  1:21 ` Biao Huang
  2022-03-24 10:19   ` Paolo Abeni
                     ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Biao Huang @ 2022-03-24  1:21 UTC (permalink / raw)
  To: davem, Jakub Kicinski, Rob Herring
  Cc: Matthias Brugger, Giuseppe Cavallaro, Alexandre Torgue,
	Jose Abreu, Biao Huang, netdev, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, srv_heupstream, macpaul.lin

PBL can be any of the following values: 1, 2, 4, 8, 16 or 32
according to the datasheet, so modify available values of PBL in
snps,dwmac.yaml.

Signed-off-by: Biao Huang <biao.huang@mediatek.com>
---
 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 42689b7d03a2..856cd0b7a5b0 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -334,21 +334,21 @@ allOf:
           description:
             Programmable Burst Length (tx and rx)
           $ref: /schemas/types.yaml#/definitions/uint32
-          enum: [2, 4, 8]
+          enum: [1, 2, 4, 8, 16, 32]
 
         snps,txpbl:
           description:
             Tx Programmable Burst Length. If set, DMA tx will use this
             value rather than snps,pbl.
           $ref: /schemas/types.yaml#/definitions/uint32
-          enum: [2, 4, 8]
+          enum: [1, 2, 4, 8, 16, 32]
 
         snps,rxpbl:
           description:
             Rx Programmable Burst Length. If set, DMA rx will use this
             value rather than snps,pbl.
           $ref: /schemas/types.yaml#/definitions/uint32
-          enum: [2, 4, 8]
+          enum: [1, 2, 4, 8, 16, 32]
 
         snps,no-pbl-x8:
           $ref: /schemas/types.yaml#/definitions/flag
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL
  2022-03-24  1:21 ` [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL Biao Huang
@ 2022-03-24 10:19   ` Paolo Abeni
  2022-03-24 14:18   ` Rob Herring
  2022-03-25  1:32   ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Paolo Abeni @ 2022-03-24 10:19 UTC (permalink / raw)
  To: Rob Herring
  Cc: Matthias Brugger, Giuseppe Cavallaro, Alexandre Torgue,
	Jose Abreu, netdev, devicetree, linux-kernel, linux-arm-kernel,
	linux-mediatek, srv_heupstream, macpaul.lin, Biao Huang, davem,
	Jakub Kicinski

Hello,

On Thu, 2022-03-24 at 09:21 +0800, Biao Huang wrote:
> PBL can be any of the following values: 1, 2, 4, 8, 16 or 32
> according to the datasheet, so modify available values of PBL in
> snps,dwmac.yaml.
> 
> Signed-off-by: Biao Huang <biao.huang@mediatek.com>

@Rob: my understanding is that this patch will go through your tree,
despite being marked as net-next. Please correct me if I'm wrong,
thanks!

Paolo


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL
  2022-03-24  1:21 ` [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL Biao Huang
  2022-03-24 10:19   ` Paolo Abeni
@ 2022-03-24 14:18   ` Rob Herring
  2022-03-25  1:32   ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-03-24 14:18 UTC (permalink / raw)
  To: Biao Huang
  Cc: Rob Herring, Giuseppe Cavallaro, Matthias Brugger, netdev,
	macpaul.lin, linux-kernel, srv_heupstream, Jose Abreu,
	Alexandre Torgue, linux-mediatek, Jakub Kicinski, davem,
	devicetree, linux-arm-kernel

On Thu, 24 Mar 2022 09:21:12 +0800, Biao Huang wrote:
> PBL can be any of the following values: 1, 2, 4, 8, 16 or 32
> according to the datasheet, so modify available values of PBL in
> snps,dwmac.yaml.
> 
> Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> ---
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1608860


dwmac@9630000: $nodename:0: 'dwmac@9630000' does not match '^ethernet(@.*)?$'
	arch/arm/boot/dts/stih407-b2120.dt.yaml
	arch/arm/boot/dts/stih410-b2120.dt.yaml
	arch/arm/boot/dts/stih410-b2260.dt.yaml
	arch/arm/boot/dts/stih418-b2199.dt.yaml
	arch/arm/boot/dts/stih418-b2264.dt.yaml

eth@5c400000: $nodename:0: 'eth@5c400000' does not match '^ethernet(@.*)?$'
	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c400000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema
	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c500000: $nodename:0: 'eth@5c500000' does not match '^ethernet(@.*)?$'
	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c500000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema
	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c600000: $nodename:0: 'eth@5c600000' does not match '^ethernet(@.*)?$'
	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c600000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema
	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c700000: $nodename:0: 'eth@5c700000' does not match '^ethernet(@.*)?$'
	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c700000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema
	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@e0800000: $nodename:0: 'eth@e0800000' does not match '^ethernet(@.*)?$'
	arch/arm/boot/dts/spear300-evb.dt.yaml
	arch/arm/boot/dts/spear310-evb.dt.yaml
	arch/arm/boot/dts/spear320-evb.dt.yaml
	arch/arm/boot/dts/spear320-hmi.dt.yaml

eth@e2000000: $nodename:0: 'eth@e2000000' does not match '^ethernet(@.*)?$'
	arch/arm/boot/dts/spear1310-evb.dt.yaml
	arch/arm/boot/dts/spear1340-evb.dt.yaml

eth@e2000000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema
	arch/arm/boot/dts/spear1310-evb.dt.yaml
	arch/arm/boot/dts/spear1340-evb.dt.yaml

ethernet@c9410000: 'phy-mode' is a required property
	arch/arm/boot/dts/meson6-atv1200.dt.yaml
	arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

ethernet@e0800000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema
	arch/arm/boot/dts/spear600-evb.dt.yaml

ethernet@f8010000: interrupt-names:1: 'eth_wake_irq' was expected
	arch/arm/boot/dts/artpec6-devboard.dt.yaml

ethernet@fe2a0000: clock-names: ['stmmaceth', 'mac_clk_rx', 'mac_clk_tx', 'clk_mac_refout', 'aclk_mac', 'pclk_mac', 'clk_mac_speed', 'ptp_ref', 'pclk_xpcs'] is too long
	arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml

ethernet@fe2a0000: clocks: [[15, 386], [15, 389], [15, 389], [15, 184], [15, 180], [15, 181], [15, 389], [15, 185], [15, 172]] is too long
	arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml

ethernet@ff800000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff800000: resets: [[6, 32], [6, 40]] is too long
	arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff800000: resets: [[7, 32], [7, 40]] is too long
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml

ethernet@ff802000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff802000: resets: [[6, 33], [6, 41]] is too long
	arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff802000: resets: [[7, 33], [7, 41]] is too long
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml

ethernet@ff804000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff804000: resets: [[6, 34], [6, 42]] is too long
	arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml
	arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff804000: resets: [[7, 34], [7, 42]] is too long
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml
	arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml
	arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml

eth@f0802000: $nodename:0: 'eth@f0802000' does not match '^ethernet(@.*)?$'
	arch/arm/boot/dts/nuvoton-npcm730-gbs.dt.yaml
	arch/arm/boot/dts/nuvoton-npcm730-gsj.dt.yaml
	arch/arm/boot/dts/nuvoton-npcm730-kudo.dt.yaml
	arch/arm/boot/dts/nuvoton-npcm750-evb.dt.yaml
	arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dt.yaml

eth@f0804000: $nodename:0: 'eth@f0804000' does not match '^ethernet(@.*)?$'
	arch/arm/boot/dts/nuvoton-npcm750-evb.dt.yaml
	arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dt.yaml


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL
  2022-03-24  1:21 ` [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL Biao Huang
  2022-03-24 10:19   ` Paolo Abeni
  2022-03-24 14:18   ` Rob Herring
@ 2022-03-25  1:32   ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-03-25  1:32 UTC (permalink / raw)
  To: Biao Huang
  Cc: davem, netdev, linux-arm-kernel, Rob Herring, Alexandre Torgue,
	Jose Abreu, linux-mediatek, Giuseppe Cavallaro, linux-kernel,
	macpaul.lin, Jakub Kicinski, devicetree, Matthias Brugger,
	srv_heupstream

On Thu, 24 Mar 2022 09:21:12 +0800, Biao Huang wrote:
> PBL can be any of the following values: 1, 2, 4, 8, 16 or 32
> according to the datasheet, so modify available values of PBL in
> snps,dwmac.yaml.
> 
> Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> ---
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-03-25  1:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24  1:21 [PATCH net-next 0/1] modify PBL values in snps,dwmac.yaml Biao Huang
2022-03-24  1:21 ` [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL Biao Huang
2022-03-24 10:19   ` Paolo Abeni
2022-03-24 14:18   ` Rob Herring
2022-03-25  1:32   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).