* [PATCH net-next] net: mark tulip obsolete
@ 2022-03-15 18:43 Jakub Kicinski
2022-03-15 18:44 ` Helge Deller
0 siblings, 1 reply; 7+ messages in thread
From: Jakub Kicinski @ 2022-03-15 18:43 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-parisc, Jakub Kicinski
It's ancient, an likely completely unused at this point.
Let's mark it obsolete to prevent refactoring.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1397a6b039fb..9afe495a86ca 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19687,7 +19687,7 @@ F: drivers/media/tuners/tua9001*
TULIP NETWORK DRIVERS
L: netdev@vger.kernel.org
L: linux-parisc@vger.kernel.org
-S: Orphan
+S: Orphan / Obsolete
F: drivers/net/ethernet/dec/tulip/
TUN/TAP driver
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] net: mark tulip obsolete
2022-03-15 18:43 [PATCH net-next] net: mark tulip obsolete Jakub Kicinski
@ 2022-03-15 18:44 ` Helge Deller
2022-03-15 19:04 ` Jakub Kicinski
0 siblings, 1 reply; 7+ messages in thread
From: Helge Deller @ 2022-03-15 18:44 UTC (permalink / raw)
To: Jakub Kicinski, davem; +Cc: netdev, linux-parisc
On 3/15/22 19:43, Jakub Kicinski wrote:
> It's ancient, an likely completely unused at this point.
> Let's mark it obsolete to prevent refactoring.
NAK.
This driver is needed by nearly all PA-RISC machines.
Helge
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1397a6b039fb..9afe495a86ca 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19687,7 +19687,7 @@ F: drivers/media/tuners/tua9001*
> TULIP NETWORK DRIVERS
> L: netdev@vger.kernel.org
> L: linux-parisc@vger.kernel.org
> -S: Orphan
> +S: Orphan / Obsolete
> F: drivers/net/ethernet/dec/tulip/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] net: mark tulip obsolete
2022-03-15 18:44 ` Helge Deller
@ 2022-03-15 19:04 ` Jakub Kicinski
2022-03-15 22:18 ` Helge Deller
0 siblings, 1 reply; 7+ messages in thread
From: Jakub Kicinski @ 2022-03-15 19:04 UTC (permalink / raw)
To: Helge Deller; +Cc: davem, netdev, linux-parisc
On Tue, 15 Mar 2022 19:44:24 +0100 Helge Deller wrote:
> On 3/15/22 19:43, Jakub Kicinski wrote:
> > It's ancient, an likely completely unused at this point.
> > Let's mark it obsolete to prevent refactoring.
>
> NAK.
>
> This driver is needed by nearly all PA-RISC machines.
I was just trying to steer newcomers to code that's more relevant today.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] net: mark tulip obsolete
2022-03-15 19:04 ` Jakub Kicinski
@ 2022-03-15 22:18 ` Helge Deller
2022-04-26 12:53 ` Jakub Kicinski
0 siblings, 1 reply; 7+ messages in thread
From: Helge Deller @ 2022-03-15 22:18 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, linux-parisc
On 3/15/22 20:04, Jakub Kicinski wrote:
> On Tue, 15 Mar 2022 19:44:24 +0100 Helge Deller wrote:
>> On 3/15/22 19:43, Jakub Kicinski wrote:
>>> It's ancient, an likely completely unused at this point.
>>> Let's mark it obsolete to prevent refactoring.
>>
>> NAK.
>>
>> This driver is needed by nearly all PA-RISC machines.
>
> I was just trying to steer newcomers to code that's more relevant today.
That intention is ok, but "obsolete" means it's not used any more,
and that's not true.
Helge
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] net: mark tulip obsolete
2022-03-15 22:18 ` Helge Deller
@ 2022-04-26 12:53 ` Jakub Kicinski
2022-04-26 20:53 ` Helge Deller
0 siblings, 1 reply; 7+ messages in thread
From: Jakub Kicinski @ 2022-04-26 12:53 UTC (permalink / raw)
To: Helge Deller; +Cc: davem, netdev, linux-parisc
On Tue, 15 Mar 2022 23:18:38 +0100 Helge Deller wrote:
> On 3/15/22 20:04, Jakub Kicinski wrote:
> > On Tue, 15 Mar 2022 19:44:24 +0100 Helge Deller wrote:
> >> On 3/15/22 19:43, Jakub Kicinski wrote:
> >>> It's ancient, an likely completely unused at this point.
> >>> Let's mark it obsolete to prevent refactoring.
> >>
> >> NAK.
> >>
> >> This driver is needed by nearly all PA-RISC machines.
> >
> > I was just trying to steer newcomers to code that's more relevant today.
>
> That intention is ok, but "obsolete" means it's not used any more,
> and that's not true.
Hi Helge! Which incarnation of tulip do you need for PA-RISC, exactly?
I'd like to try to remove DE4X5, if that's not the one you need
(getting rid of virt_to_bus()-using drivers).
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] net: mark tulip obsolete
2022-04-26 12:53 ` Jakub Kicinski
@ 2022-04-26 20:53 ` Helge Deller
2022-04-26 21:31 ` Jakub Kicinski
0 siblings, 1 reply; 7+ messages in thread
From: Helge Deller @ 2022-04-26 20:53 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, linux-parisc, linux-alpha
Hi Jakub,
On 4/26/22 14:53, Jakub Kicinski wrote:
> On Tue, 15 Mar 2022 23:18:38 +0100 Helge Deller wrote:
>> On 3/15/22 20:04, Jakub Kicinski wrote:
>>> On Tue, 15 Mar 2022 19:44:24 +0100 Helge Deller wrote:
>>>> On 3/15/22 19:43, Jakub Kicinski wrote:
>>>>> It's ancient, an likely completely unused at this point.
>>>>> Let's mark it obsolete to prevent refactoring.
>>>>
>>>> NAK.
>>>>
>>>> This driver is needed by nearly all PA-RISC machines.
>>>
>>> I was just trying to steer newcomers to code that's more relevant today.
>>
>> That intention is ok, but "obsolete" means it's not used any more,
>> and that's not true.
>
> Hi Helge! Which incarnation of tulip do you need for PA-RISC, exactly?
For parisc I have:
CONFIG_NET_TULIP=y
# CONFIG_DE2104X is not set
CONFIG_TULIP=y
# CONFIG_TULIP_MWI is not set
# CONFIG_TULIP_MMIO is not set
# CONFIG_TULIP_NAPI is not set
# CONFIG_DE4X5 is not set
# CONFIG_WINBOND_840 is not set
# CONFIG_DM9102 is not set
# CONFIG_ULI526X is not set
# CONFIG_PCMCIA_XIRCOM is not set
# CONFIG_NET_VENDOR_DLINK is not set
# CONFIG_NET_VENDOR_EMULEX is not set
So not the DE4X5.
> I'd like to try to remove DE4X5, if that's not the one you need
> (getting rid of virt_to_bus()-using drivers).
I've CC'ed the linux-alpha mailing list, as the DE4X5 driver might be
needed there, so removing it completely might not be the best idea.
But since you want to remove virt_to_bus()....
It seems this virt_to_bus() call is used for really old x86 machines/cards,
which probably aren't supported any longer.
See drivers/net/ethernet/dec/tulip/de4x5.c:
...
#if !defined(__alpha__) && !defined(__powerpc__) && !defined(CONFIG_SPARC) && !defined(DE4X5_DO_MEMCPY)
...
tmp = virt_to_bus(p->data);
...
Maybe you could simply remove the part inside #if...#else
and insert a pr_err() instead (and return NULL)?
Helge
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] net: mark tulip obsolete
2022-04-26 20:53 ` Helge Deller
@ 2022-04-26 21:31 ` Jakub Kicinski
0 siblings, 0 replies; 7+ messages in thread
From: Jakub Kicinski @ 2022-04-26 21:31 UTC (permalink / raw)
To: Helge Deller; +Cc: davem, netdev, linux-parisc, linux-alpha
On Tue, 26 Apr 2022 22:53:00 +0200 Helge Deller wrote:
> >> That intention is ok, but "obsolete" means it's not used any more,
> >> and that's not true.
> >
> > Hi Helge! Which incarnation of tulip do you need for PA-RISC, exactly?
>
> For parisc I have:
>
> CONFIG_NET_TULIP=y
> # CONFIG_DE2104X is not set
> CONFIG_TULIP=y
> # CONFIG_TULIP_MWI is not set
> # CONFIG_TULIP_MMIO is not set
> # CONFIG_TULIP_NAPI is not set
> # CONFIG_DE4X5 is not set
> # CONFIG_WINBOND_840 is not set
> # CONFIG_DM9102 is not set
> # CONFIG_ULI526X is not set
> # CONFIG_PCMCIA_XIRCOM is not set
> # CONFIG_NET_VENDOR_DLINK is not set
> # CONFIG_NET_VENDOR_EMULEX is not set
>
> So not the DE4X5.
>
> > I'd like to try to remove DE4X5, if that's not the one you need
> > (getting rid of virt_to_bus()-using drivers).
>
> I've CC'ed the linux-alpha mailing list, as the DE4X5 driver might be
> needed there, so removing it completely might not be the best idea.
>
> But since you want to remove virt_to_bus()....
> It seems this virt_to_bus() call is used for really old x86 machines/cards,
> which probably aren't supported any longer.
>
> See drivers/net/ethernet/dec/tulip/de4x5.c:
> ...
> #if !defined(__alpha__) && !defined(__powerpc__) && !defined(CONFIG_SPARC) && !defined(DE4X5_DO_MEMCPY)
> ...
> tmp = virt_to_bus(p->data);
> ...
>
> Maybe you could simply remove the part inside #if...#else
> and insert a pr_err() instead (and return NULL)?
Ah, good find, thanks for taking a look! I'll look into dropping just
sections of the code.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-04-26 21:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15 18:43 [PATCH net-next] net: mark tulip obsolete Jakub Kicinski
2022-03-15 18:44 ` Helge Deller
2022-03-15 19:04 ` Jakub Kicinski
2022-03-15 22:18 ` Helge Deller
2022-04-26 12:53 ` Jakub Kicinski
2022-04-26 20:53 ` Helge Deller
2022-04-26 21:31 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).