* [PATCH] dt-bindings: net: Fix unevaluatedProperties warnings in examples
@ 2022-05-26 1:41 Rob Herring
2022-05-30 9:03 ` Nicolas Ferre
2022-05-31 15:20 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2022-05-26 1:41 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Krzysztof Kozlowski, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Kalle Valo, Matthias Brugger,
Nicolas Ferre, Claudiu Beznea, Biao Huang
Cc: netdev, devicetree, linux-kernel, linux-wireless,
linux-arm-kernel, linux-mediatek
The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples. Fix the warnings by removing
spurious properties or adding missing properties to the schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 -
Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 3 +++
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 2 +-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
index 337cec4d85ca..86fc31c2d91b 100644
--- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
+++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
@@ -191,7 +191,6 @@ examples:
clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
#address-cells = <1>;
#size-cells = <0>;
- #stream-id-cells = <1>;
iommus = <&smmu 0x875>;
power-domains = <&zynqmp_firmware PD_ETH_1>;
resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>;
diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index 699164dd1295..f5564ecddb62 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -27,6 +27,9 @@ properties:
reg:
maxItems: 1
+ clocks: true
+ clock-names: true
+
interrupts:
minItems: 3
maxItems: 4
diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
index 901944683322..61b2fb9e141b 100644
--- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
@@ -58,6 +58,9 @@ properties:
- const: rmii_internal
- const: mac_cg
+ power-domains:
+ maxItems: 1
+
mediatek,pericfg:
$ref: /schemas/types.yaml#/definitions/phandle
description:
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 249967d8d750..5a12dc32288a 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -51,7 +51,7 @@ properties:
description:
Specify the consys reset for mt7986.
- reset-name:
+ reset-names:
const: consys
mediatek,infracfg:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: net: Fix unevaluatedProperties warnings in examples
2022-05-26 1:41 [PATCH] dt-bindings: net: Fix unevaluatedProperties warnings in examples Rob Herring
@ 2022-05-30 9:03 ` Nicolas Ferre
2022-05-31 15:20 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2022-05-30 9:03 UTC (permalink / raw)
To: Rob Herring, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Krzysztof Kozlowski, Felix Fietkau,
Lorenzo Bianconi, Ryder Lee, Shayne Chen, Sean Wang, Kalle Valo,
Matthias Brugger, Claudiu Beznea, Biao Huang
Cc: netdev, devicetree, linux-kernel, linux-wireless,
linux-arm-kernel, linux-mediatek
On 26/05/2022 at 03:41, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples. Fix the warnings by removing
> spurious properties or adding missing properties to the schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 -
> Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
> Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 3 +++
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 2 +-
> 4 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 337cec4d85ca..86fc31c2d91b 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -191,7 +191,6 @@ examples:
> clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> #address-cells = <1>;
> #size-cells = <0>;
> - #stream-id-cells = <1>;
> iommus = <&smmu 0x875>;
> power-domains = <&zynqmp_firmware PD_ETH_1>;
> resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>;
For cdns,macb.yaml:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks Rob. Best regards,
Nicolas
> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> index 699164dd1295..f5564ecddb62 100644
> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> @@ -27,6 +27,9 @@ properties:
> reg:
> maxItems: 1
>
> + clocks: true
> + clock-names: true
> +
> interrupts:
> minItems: 3
> maxItems: 4
> diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> index 901944683322..61b2fb9e141b 100644
> --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> @@ -58,6 +58,9 @@ properties:
> - const: rmii_internal
> - const: mac_cg
>
> + power-domains:
> + maxItems: 1
> +
> mediatek,pericfg:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 249967d8d750..5a12dc32288a 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -51,7 +51,7 @@ properties:
> description:
> Specify the consys reset for mt7986.
>
> - reset-name:
> + reset-names:
> const: consys
>
> mediatek,infracfg:
> --
> 2.34.1
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: net: Fix unevaluatedProperties warnings in examples
2022-05-26 1:41 [PATCH] dt-bindings: net: Fix unevaluatedProperties warnings in examples Rob Herring
2022-05-30 9:03 ` Nicolas Ferre
@ 2022-05-31 15:20 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-05-31 15:20 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Krzysztof Kozlowski, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Kalle Valo, Matthias Brugger,
Nicolas Ferre, Claudiu Beznea, Biao Huang
Cc: netdev, devicetree, linux-kernel, linux-wireless,
linux-arm-kernel, linux-mediatek
On Wed, May 25, 2022 at 08:41:48PM -0500, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples. Fix the warnings by removing
> spurious properties or adding missing properties to the schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 -
> Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
> Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 3 +++
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 2 +-
> 4 files changed, 7 insertions(+), 2 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-31 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 1:41 [PATCH] dt-bindings: net: Fix unevaluatedProperties warnings in examples Rob Herring
2022-05-30 9:03 ` Nicolas Ferre
2022-05-31 15:20 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).