[PATCH net-next 0/2] Document PolarFire SoC can controller

[PATCH net-next 0/2] Document PolarFire SoC can controller

[Conor Dooley]

Hey,
When adding the dts for PolarFire SoC, the can controllers were omitted,
so here they are...

Thanks,
Conor.

Conor Dooley (2):
  dt-bindings: can: mpfs: document the mpfs can controller
  riscv: dts: microchip: add mpfs's can controllers

 .../bindings/net/can/microchip,mpfs-can.yaml  | 45 +++++++++++++++++++
 .../boot/dts/microchip/microchip-mpfs.dtsi    | 18 ++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml

-- 
2.36.1

[PATCH net-next 1/2] dt-bindings: can: mpfs: document the mpfs can controller

[Conor Dooley]

Add a binding for the can controller on PolarFire SoC (MPFS).

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../bindings/net/can/microchip,mpfs-can.yaml  | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml

diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
new file mode 100644
index 000000000000..45aa3de7cf01
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/microchip,mpfs-can.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title:
+  Microchip PolarFire SoC (MPFS) can controller
+
+maintainers:
+  - Conor Dooley <conor.dooley@microchip.com>
+
+allOf:
+  - $ref: can-controller.yaml#
+
+properties:
+  compatible:
+    const: microchip,mpfs-can
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    can@2010c000 {
+        compatible = "microchip,mpfs-can";
+        reg = <0x2010c000 0x1000>;
+        clocks = <&clkcfg 17>;
+        interrupt-parent = <&plic>;
+        interrupts = <56>;
+    };
-- 
2.36.1

Re: [PATCH net-next 1/2] dt-bindings: can: mpfs: document the mpfs can controller

[Rob Herring]

On Tue, 07 Jun 2022 07:54:59 +0100, Conor Dooley wrote:
> Add a binding for the can controller on PolarFire SoC (MPFS).
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  .../bindings/net/can/microchip,mpfs-can.yaml  | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

[PATCH net-next 2/2] riscv: dts: microchip: add mpfs's can controllers

[Conor Dooley]

PolarFire SoC has a pair of can controllers, but as they were
undocumented there were omitted from the device tree. Add them.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../boot/dts/microchip/microchip-mpfs.dtsi     | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
index cf2f55e1dcb6..059a671314bf 100644
--- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
+++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
@@ -326,6 +326,24 @@ i2c1: i2c@2010b000 {
 			status = "disabled";
 		};
 
+		can0: can@2010c000 {
+			compatible = "microchip,mpfs-can";
+			reg = <0x0 0x2010c000 0x0 0x1000>;
+			clocks = <&clkcfg CLK_CAN0>;
+			interrupt-parent = <&plic>;
+			interrupts = <56>;
+			status = "disabled";
+		};
+
+		can1: can@2010d000 {
+			compatible = "microchip,mpfs-can";
+			reg = <0x0 0x2010d000 0x0 0x1000>;
+			clocks = <&clkcfg CLK_CAN1>;
+			interrupt-parent = <&plic>;
+			interrupts = <57>;
+			status = "disabled";
+		};
+
 		mac0: ethernet@20110000 {
 			compatible = "cdns,macb";
 			reg = <0x0 0x20110000 0x0 0x2000>;
-- 
2.36.1

Re: [PATCH net-next 0/2] Document PolarFire SoC can controller

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

On 07.06.2022 07:54:58, Conor Dooley wrote:
> When adding the dts for PolarFire SoC, the can controllers were
                                             ^^^
> omitted, so here they are...

Nitpick:
Consider writing "CAN" in capital letters to avoid confusion for the not
informed reader.

Is the documentation for the CAN controller openly available? Is there a
driver somewhere?

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH net-next 0/2] Document PolarFire SoC can controller

[Conor.Dooley]

On 07/06/2022 08:15, Marc Kleine-Budde wrote:
> On 07.06.2022 07:54:58, Conor Dooley wrote:
>> When adding the dts for PolarFire SoC, the can controllers were
>                                               ^^^
>> omitted, so here they are...
> 
> Nitpick:
> Consider writing "CAN" in capital letters to avoid confusion for the not
> informed reader.

Yeah, sure. I'll try to get over my fear of capital letters ;)

> 
> Is the documentation for the CAN controller openly available? Is there a
> driver somewhere?

There is a driver /but/ for now only a UIO one so I didn't send it.
There's an online doc & if the horrible link doesn't drop you there
directly, its section 6.12.3:
https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66

And a PDF direct download here, see section 4.12.3 (page 72):
https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual

Thanks,
Conor.

Re: [PATCH net-next 0/2] Document PolarFire SoC can controller

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]

On 07.06.2022 07:52:30, Conor.Dooley@microchip.com wrote:
> On 07/06/2022 08:15, Marc Kleine-Budde wrote:
> > On 07.06.2022 07:54:58, Conor Dooley wrote:
> >> When adding the dts for PolarFire SoC, the can controllers were
> >                                             ^^^
> >> omitted, so here they are...
> > 
> > Nitpick:
> > Consider writing "CAN" in capital letters to avoid confusion for the not
> > informed reader.
> 
> Yeah, sure. I'll try to get over my fear of capital letters ;)

:)

> > Is the documentation for the CAN controller openly available? Is there a
> > driver somewhere?
> 
> There is a driver /but/ for now only a UIO one so I didn't send it.

Brrrrr...

> There's an online doc & if the horrible link doesn't drop you there
> directly, its section 6.12.3:
> https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66
> 
> And a PDF direct download here, see section 4.12.3 (page 72):
> https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual

Thanks. The documentation is quite sparse, is there a more detailed one?
The register map cannot be downloaded directly anymore. For reference:

http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH net-next 0/2] Document PolarFire SoC can controller

[Conor.Dooley]

On 07/06/2022 09:28, Marc Kleine-Budde wrote:
> On 07.06.2022 07:52:30, Conor.Dooley@microchip.com wrote:
>> On 07/06/2022 08:15, Marc Kleine-Budde wrote:
>>> On 07.06.2022 07:54:58, Conor Dooley wrote:
>>>> When adding the dts for PolarFire SoC, the can controllers were
>>>                                              ^^^
>>>> omitted, so here they are...
>>>
>>> Nitpick:
>>> Consider writing "CAN" in capital letters to avoid confusion for the not
>>> informed reader.
>>
>> Yeah, sure. I'll try to get over my fear of capital letters ;)
> 
> :)
> 
>>> Is the documentation for the CAN controller openly available? Is there a
>>> driver somewhere?
>>
>> There is a driver /but/ for now only a UIO one so I didn't send it.
> 
> Brrrrr...

Yeah, I know..

> 
>> There's an online doc & if the horrible link doesn't drop you there
>> directly, its section 6.12.3:
>> https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66
>>
>> And a PDF direct download here, see section 4.12.3 (page 72):
>> https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual
> 
> Thanks. The documentation is quite sparse, is there a more detailed one?

Nope, that's all I've got...

> The register map cannot be downloaded directly anymore. For reference:
> 
> http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map

Oh that sucks. I know we have had some website issues over the weekend
which might be the problem there. I'll try to bring it up and find out.

> 
> regards,
> Marc
> 

Re: [PATCH net-next 0/2] Document PolarFire SoC can controller

[Conor.Dooley]

On 07/06/2022 09:54, Conor.Dooley@microchip.com wrote:
> On 07/06/2022 09:28, Marc Kleine-Budde wrote:
>> On 07.06.2022 07:52:30, Conor.Dooley@microchip.com wrote:
>>> On 07/06/2022 08:15, Marc Kleine-Budde wrote:
>>>> On 07.06.2022 07:54:58, Conor Dooley wrote:
>>>>> When adding the dts for PolarFire SoC, the can controllers were
>>>>                                               ^^^
>>>>> omitted, so here they are...
>>>>
>>>> Nitpick:
>>>> Consider writing "CAN" in capital letters to avoid confusion for the not
>>>> informed reader.
>>>
>>> Yeah, sure. I'll try to get over my fear of capital letters ;)
>>
>> :)
>>
>>>> Is the documentation for the CAN controller openly available? Is there a
>>>> driver somewhere?
>>>
>>> There is a driver /but/ for now only a UIO one so I didn't send it.
>>
>> Brrrrr...
> 
> Yeah, I know..
> 
>>
>>> There's an online doc & if the horrible link doesn't drop you there
>>> directly, its section 6.12.3:
>>> https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66
>>>
>>> And a PDF direct download here, see section 4.12.3 (page 72):
>>> https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual
>>
>> Thanks. The documentation is quite sparse, is there a more detailed one?
> 
> Nope, that's all I've got...
> 
>> The register map cannot be downloaded directly anymore. For reference:
>>
>> http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
> 
> Oh that sucks. I know we have had some website issues over the weekend
> which might be the problem there. I'll try to bring it up and find out.
> 

Hey Marc,
Doc is still not available but should be getting fixed.
What do I need to do for this binding? Are you happy to accept it without
a driver if I add links to the documentation and a working link to the
register map?
Thanks,
Conor.

Re: [PATCH net-next 0/2] Document PolarFire SoC can controller

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

On 13.06.2022 12:52:00, Conor.Dooley@microchip.com wrote:
> >> The register map cannot be downloaded directly anymore. For reference:
> >>
> >> http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
> > 
> > Oh that sucks. I know we have had some website issues over the weekend
> > which might be the problem there. I'll try to bring it up and find out.
> > 
> 
> Hey Marc,
> Doc is still not available but should be getting fixed.

Thanks.

> What do I need to do for this binding? Are you happy to accept it without
> a driver if I add links to the documentation and a working link to the
> register map?

I'm taking both patches and change the CAN into capital letters while
applying, I'll also add a link to the datasheets.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH net-next 0/2] Document PolarFire SoC can controller

[Conor.Dooley]

On 13/06/2022 14:45, Marc Kleine-Budde wrote:
> On 13.06.2022 12:52:00, Conor.Dooley@microchip.com wrote:
>>>> The register map cannot be downloaded directly anymore. For reference:
>>>>
>>>> http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
>>>
>>> Oh that sucks. I know we have had some website issues over the weekend
>>> which might be the problem there. I'll try to bring it up and find out.
>>>
>>
>> Hey Marc,
>> Doc is still not available but should be getting fixed.
> 
> Thanks.
> 
>> What do I need to do for this binding? Are you happy to accept it without
>> a driver if I add links to the documentation and a working link to the
>> register map?
> 
> I'm taking both patches and change the CAN into capital letters while
> applying, I'll also add a link to the datasheets.

Cool, SGTM.
Thanks,
Conor.