[PATCH] wifi: mac80211: remove redundant pointer bss

[PATCH] wifi: mac80211: remove redundant pointer bss

[Colin Ian King]

The pointer bss is being assigned a value that is never read, the
pointer is redundant and can be removed.

Cleans up clang scan-build warning:
drivers/net/wireless/rsi/rsi_91x_hal.c:362:2: warning: Value stored
to 'bss' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/wireless/rsi/rsi_91x_hal.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
index 40f9a31f9ca7..c61f83a7333b 100644
--- a/drivers/net/wireless/rsi/rsi_91x_hal.c
+++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
@@ -334,7 +334,6 @@ int rsi_send_mgmt_pkt(struct rsi_common *common,
 		      struct sk_buff *skb)
 {
 	struct rsi_hw *adapter = common->priv;
-	struct ieee80211_bss_conf *bss;
 	struct ieee80211_hdr *wh;
 	struct ieee80211_tx_info *info;
 	struct skb_info *tx_params;
@@ -359,7 +358,6 @@ int rsi_send_mgmt_pkt(struct rsi_common *common,
 		return status;
 	}
 
-	bss = &info->control.vif->bss_conf;
 	wh = (struct ieee80211_hdr *)&skb->data[header_size];
 	mgmt_desc = (struct rsi_mgmt_desc *)skb->data;
 	xtend_desc = (struct rsi_xtended_desc *)&skb->data[FRAME_DESC_SZ];
-- 
2.35.3

Re: wifi: rsi: remove redundant pointer bss

[Kalle Valo]

Colin Ian King <colin.i.king@gmail.com> wrote:

> The pointer bss is being assigned a value that is never read, the
> pointer is redundant and can be removed.
> 
> Cleans up clang scan-build warning:
> drivers/net/wireless/rsi/rsi_91x_hal.c:362:2: warning: Value stored
> to 'bss' is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Already fixed in: https://git.kernel.org/netdev/net-next/c/9dd9495d560a

Patch set to Superseded.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220622113402.16969-1-colin.i.king@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches