* [PATCH] net: sungem_phy: Add of_node_put() for reference returned by of_get_parent()
@ 2022-07-20 13:10 Liang He
2022-07-22 2:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-07-20 13:10 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, netdev, windhl
In bcm5421_init(), we should call of_node_put() for the reference
returned by of_get_parent() which has increased the refcount.
Fixes: 3c326fe9cb7a ("[PATCH] ppc64: Add new PHY to sungem")
Signed-off-by: Liang He <windhl@126.com>
---
drivers/net/sungem_phy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
index ff22b6b1c686..36803d932dff 100644
--- a/drivers/net/sungem_phy.c
+++ b/drivers/net/sungem_phy.c
@@ -450,6 +450,7 @@ static int bcm5421_init(struct mii_phy* phy)
int can_low_power = 1;
if (np == NULL || of_get_property(np, "no-autolowpower", NULL))
can_low_power = 0;
+ of_node_put(np);
if (can_low_power) {
/* Enable automatic low-power */
sungem_phy_write(phy, 0x1c, 0x9002);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: sungem_phy: Add of_node_put() for reference returned by of_get_parent()
2022-07-20 13:10 [PATCH] net: sungem_phy: Add of_node_put() for reference returned by of_get_parent() Liang He
@ 2022-07-22 2:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-22 2:20 UTC (permalink / raw)
To: Liang He; +Cc: davem, edumazet, kuba, pabeni, netdev
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 20 Jul 2022 21:10:03 +0800 you wrote:
> In bcm5421_init(), we should call of_node_put() for the reference
> returned by of_get_parent() which has increased the refcount.
>
> Fixes: 3c326fe9cb7a ("[PATCH] ppc64: Add new PHY to sungem")
> Signed-off-by: Liang He <windhl@126.com>
> ---
> drivers/net/sungem_phy.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- net: sungem_phy: Add of_node_put() for reference returned by of_get_parent()
https://git.kernel.org/netdev/net/c/ebbbe23fdf60
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-22 2:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 13:10 [PATCH] net: sungem_phy: Add of_node_put() for reference returned by of_get_parent() Liang He
2022-07-22 2:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).