* [patch net-next] mlxsw: core: Fix use-after-free calling devl_unlock() in mlxsw_core_bus_device_unregister()
@ 2022-07-21 14:24 Jiri Pirko
2022-07-21 18:01 ` Ido Schimmel
2022-07-22 22:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Pirko @ 2022-07-21 14:24 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, idosch, petrm, pabeni, edumazet, mlxsw
From: Jiri Pirko <jiri@nvidia.com>
Do devl_unlock() before freeing the devlink in
mlxsw_core_bus_device_unregister() function.
Reported-by: Ido Schimmel <idosch@nvidia.com>
Fixes: 72a4c8c94efa ("mlxsw: convert driver to use unlocked devlink API during init/fini")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
index 61eb96b93889..1b61bc8f59a2 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -2296,8 +2296,8 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core,
devl_resources_unregister(devlink);
mlxsw_core->bus->fini(mlxsw_core->bus_priv);
if (!reload) {
- devlink_free(devlink);
devl_unlock(devlink);
+ devlink_free(devlink);
}
return;
@@ -2305,8 +2305,8 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core,
reload_fail_deinit:
mlxsw_core_params_unregister(mlxsw_core);
devl_resources_unregister(devlink);
- devlink_free(devlink);
devl_unlock(devlink);
+ devlink_free(devlink);
}
EXPORT_SYMBOL(mlxsw_core_bus_device_unregister);
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch net-next] mlxsw: core: Fix use-after-free calling devl_unlock() in mlxsw_core_bus_device_unregister()
2022-07-21 14:24 [patch net-next] mlxsw: core: Fix use-after-free calling devl_unlock() in mlxsw_core_bus_device_unregister() Jiri Pirko
@ 2022-07-21 18:01 ` Ido Schimmel
2022-07-22 22:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2022-07-21 18:01 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, davem, kuba, petrm, pabeni, edumazet, mlxsw
On Thu, Jul 21, 2022 at 04:24:24PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> Do devl_unlock() before freeing the devlink in
> mlxsw_core_bus_device_unregister() function.
>
> Reported-by: Ido Schimmel <idosch@nvidia.com>
> Fixes: 72a4c8c94efa ("mlxsw: convert driver to use unlocked devlink API during init/fini")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch net-next] mlxsw: core: Fix use-after-free calling devl_unlock() in mlxsw_core_bus_device_unregister()
2022-07-21 14:24 [patch net-next] mlxsw: core: Fix use-after-free calling devl_unlock() in mlxsw_core_bus_device_unregister() Jiri Pirko
2022-07-21 18:01 ` Ido Schimmel
@ 2022-07-22 22:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-22 22:00 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, davem, kuba, idosch, petrm, pabeni, edumazet, mlxsw
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 21 Jul 2022 16:24:24 +0200 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> Do devl_unlock() before freeing the devlink in
> mlxsw_core_bus_device_unregister() function.
>
> Reported-by: Ido Schimmel <idosch@nvidia.com>
> Fixes: 72a4c8c94efa ("mlxsw: convert driver to use unlocked devlink API during init/fini")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>
> [...]
Here is the summary with links:
- [net-next] mlxsw: core: Fix use-after-free calling devl_unlock() in mlxsw_core_bus_device_unregister()
https://git.kernel.org/netdev/net-next/c/1b5995e370e4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-22 22:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21 14:24 [patch net-next] mlxsw: core: Fix use-after-free calling devl_unlock() in mlxsw_core_bus_device_unregister() Jiri Pirko
2022-07-21 18:01 ` Ido Schimmel
2022-07-22 22:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).