[PATCH net] net: dsa: fix reference counting for LAG FDBs

[PATCH net] net: dsa: fix reference counting for LAG FDBs

[Vladimir Oltean]

Due to an invalid conflict resolution on my side while working on 2
different series (LAG FDBs and FDB isolation), dsa_switch_do_lag_fdb_add()
does not store the database associated with a dsa_mac_addr structure.

So after adding an FDB entry associated with a LAG, dsa_mac_addr_find()
fails to find it while deleting it, because &a->db is zeroized memory
for all stored FDB entries of lag->fdbs, and dsa_switch_do_lag_fdb_del()
returns -ENOENT rather than deleting the entry.

Fixes: c26933639b54 ("net: dsa: request drivers to perform FDB isolation")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/dsa/switch.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index 2b56218fc57c..4dfd68cf61c5 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -344,6 +344,7 @@ static int dsa_switch_do_lag_fdb_add(struct dsa_switch *ds, struct dsa_lag *lag,
 
 	ether_addr_copy(a->addr, addr);
 	a->vid = vid;
+	a->db = db;
 	refcount_set(&a->refcount, 1);
 	list_add_tail(&a->list, &lag->fdbs);
 
-- 
2.34.1

Re: [PATCH net] net: dsa: fix reference counting for LAG FDBs

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 23 Jul 2022 04:24:11 +0300 you wrote:
> Due to an invalid conflict resolution on my side while working on 2
> different series (LAG FDBs and FDB isolation), dsa_switch_do_lag_fdb_add()
> does not store the database associated with a dsa_mac_addr structure.
> 
> So after adding an FDB entry associated with a LAG, dsa_mac_addr_find()
> fails to find it while deleting it, because &a->db is zeroized memory
> for all stored FDB entries of lag->fdbs, and dsa_switch_do_lag_fdb_del()
> returns -ENOENT rather than deleting the entry.
> 
> [...]

Here is the summary with links:
  - [net] net: dsa: fix reference counting for LAG FDBs
    https://git.kernel.org/netdev/net/c/c7560d1203b7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html