* [PATCH] arm64: dts: ls1028a-qds-65bb: don't use in-band autoneg for 2500base-x
@ 2022-08-02 13:50 Vladimir Oltean
2022-08-21 13:32 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Oltean @ 2022-08-02 13:50 UTC (permalink / raw)
To: devicetree
Cc: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski,
Claudiu Manoil, linux-arm-kernel, linux-kernel, netdev
The Lynx PCS integrated with ENETC port 0 does not support in-band
autoneg for the 2500base-x SERDES protocol, and prints errors from its
phylink methods. Furthermore, the AQR112 card used for these boards does
not expect in-band autoneg either. So delete the extraneous property.
Fixes: e426d63e752b ("arm64: dts: ls1028a-qds: add overlays for various serdes protocols")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
index 40d34c8384a5..b949cac03742 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
@@ -25,7 +25,6 @@ slot1_sgmii: ethernet-phy@2 {
&enetc_port0 {
phy-handle = <&slot1_sgmii>;
phy-mode = "2500base-x";
- managed = "in-band-status";
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a-qds-65bb: don't use in-band autoneg for 2500base-x
2022-08-02 13:50 [PATCH] arm64: dts: ls1028a-qds-65bb: don't use in-band autoneg for 2500base-x Vladimir Oltean
@ 2022-08-21 13:32 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2022-08-21 13:32 UTC (permalink / raw)
To: Vladimir Oltean
Cc: devicetree, Li Yang, Rob Herring, Krzysztof Kozlowski,
Claudiu Manoil, linux-arm-kernel, linux-kernel, netdev
On Tue, Aug 02, 2022 at 04:50:06PM +0300, Vladimir Oltean wrote:
> The Lynx PCS integrated with ENETC port 0 does not support in-band
> autoneg for the 2500base-x SERDES protocol, and prints errors from its
> phylink methods. Furthermore, the AQR112 card used for these boards does
> not expect in-band autoneg either. So delete the extraneous property.
>
> Fixes: e426d63e752b ("arm64: dts: ls1028a-qds: add overlays for various serdes protocols")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-21 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 13:50 [PATCH] arm64: dts: ls1028a-qds-65bb: don't use in-band autoneg for 2500base-x Vladimir Oltean
2022-08-21 13:32 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).