* [PATCH -next] net: ieee802154: mcr20a: Switch to use dev_err_probe() helper
@ 2022-09-15 7:12 Yang Yingliang
2022-10-12 8:50 ` Stefan Schmidt
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-09-15 7:12 UTC (permalink / raw)
To: netdev, linux-wpan; +Cc: liuxuenetmail, alex.aring, stefan, davem
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ieee802154/mcr20a.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index 2fe0e4a0a0c4..f53d185e0568 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -1233,12 +1233,9 @@ mcr20a_probe(struct spi_device *spi)
}
rst_b = devm_gpiod_get(&spi->dev, "rst_b", GPIOD_OUT_HIGH);
- if (IS_ERR(rst_b)) {
- ret = PTR_ERR(rst_b);
- if (ret != -EPROBE_DEFER)
- dev_err(&spi->dev, "Failed to get 'rst_b' gpio: %d", ret);
- return ret;
- }
+ if (IS_ERR(rst_b))
+ return dev_err_probe(&spi->dev, PTR_ERR(rst_b),
+ "Failed to get 'rst_b' gpio");
/* reset mcr20a */
usleep_range(10, 20);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: ieee802154: mcr20a: Switch to use dev_err_probe() helper
2022-09-15 7:12 [PATCH -next] net: ieee802154: mcr20a: Switch to use dev_err_probe() helper Yang Yingliang
@ 2022-10-12 8:50 ` Stefan Schmidt
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Schmidt @ 2022-10-12 8:50 UTC (permalink / raw)
To: Yang Yingliang, netdev, linux-wpan; +Cc: liuxuenetmail, alex.aring, davem
Hello.
On 15.09.22 09:12, Yang Yingliang wrote:
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ieee802154/mcr20a.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
> index 2fe0e4a0a0c4..f53d185e0568 100644
> --- a/drivers/net/ieee802154/mcr20a.c
> +++ b/drivers/net/ieee802154/mcr20a.c
> @@ -1233,12 +1233,9 @@ mcr20a_probe(struct spi_device *spi)
> }
>
> rst_b = devm_gpiod_get(&spi->dev, "rst_b", GPIOD_OUT_HIGH);
> - if (IS_ERR(rst_b)) {
> - ret = PTR_ERR(rst_b);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&spi->dev, "Failed to get 'rst_b' gpio: %d", ret);
> - return ret;
> - }
> + if (IS_ERR(rst_b))
> + return dev_err_probe(&spi->dev, PTR_ERR(rst_b),
> + "Failed to get 'rst_b' gpio");
>
> /* reset mcr20a */
> usleep_range(10, 20);
This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-12 8:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 7:12 [PATCH -next] net: ieee802154: mcr20a: Switch to use dev_err_probe() helper Yang Yingliang
2022-10-12 8:50 ` Stefan Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).