* [PATCH] sfc: fix repeated words in comments
@ 2022-09-15 7:54 Jilin Yuan
2022-09-15 15:18 ` Edward Cree
0 siblings, 1 reply; 3+ messages in thread
From: Jilin Yuan @ 2022-09-15 7:54 UTC (permalink / raw)
To: ecree.xilinx, habetsm.xilinx, davem, edumazet, kuba, pabeni
Cc: netdev, linux-kernel, Jilin Yuan
Delete the redundant word 'in'.
Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
drivers/net/ethernet/sfc/bitfield.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/bitfield.h b/drivers/net/ethernet/sfc/bitfield.h
index 1f981dfe4bdc..0b502d1c3c9e 100644
--- a/drivers/net/ethernet/sfc/bitfield.h
+++ b/drivers/net/ethernet/sfc/bitfield.h
@@ -117,7 +117,7 @@ typedef union efx_oword {
*
* ( element ) << 4
*
- * The result will contain the relevant bits filled in in the range
+ * The result will contain the relevant bits filled in the range
* [0,high-low), with garbage in bits [high-low+1,...).
*/
#define EFX_EXTRACT_NATIVE(native_element, min, max, low, high) \
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sfc: fix repeated words in comments
2022-09-15 7:54 [PATCH] sfc: fix repeated words in comments Jilin Yuan
@ 2022-09-15 15:18 ` Edward Cree
0 siblings, 0 replies; 3+ messages in thread
From: Edward Cree @ 2022-09-15 15:18 UTC (permalink / raw)
To: Jilin Yuan, habetsm.xilinx, davem, edumazet, kuba, pabeni
Cc: netdev, linux-kernel
On 15/09/2022 08:54, Jilin Yuan wrote:
> Delete the redundant word 'in'.
>
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
> drivers/net/ethernet/sfc/bitfield.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/bitfield.h b/drivers/net/ethernet/sfc/bitfield.h
> index 1f981dfe4bdc..0b502d1c3c9e 100644
> --- a/drivers/net/ethernet/sfc/bitfield.h
> +++ b/drivers/net/ethernet/sfc/bitfield.h
> @@ -117,7 +117,7 @@ typedef union efx_oword {
> *
> * ( element ) << 4
> *
> - * The result will contain the relevant bits filled in in the range
> + * The result will contain the relevant bits filled in the range
> * [0,high-low), with garbage in bits [high-low+1,...).
> */
> #define EFX_EXTRACT_NATIVE(native_element, min, max, low, high) \
>
NACK, per [1].
Please stop using whatever tool is finding these, or find someone who can
filter out the false positives.
-ed
[1]: https://lore.kernel.org/netdev/30f2488d-9af3-fe8d-6e6f-713a7d38800b@gmail.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] sfc: fix repeated words in comments
@ 2022-06-25 6:12 Jilin Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Jilin Yuan @ 2022-06-25 6:12 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni
Cc: ecree.xilinx, habetsm.xilinx, netdev, linux-kernel, Jilin Yuan
Delete the redundant word 'set'.
Delete the redundant word 'a'.
Delete the redundant word 'in'.
Found the same error as before.
Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
drivers/net/ethernet/sfc/mcdi_pcol.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sfc/mcdi_pcol.h b/drivers/net/ethernet/sfc/mcdi_pcol.h
index ff617b1b38d3..7984f6f84a3c 100644
--- a/drivers/net/ethernet/sfc/mcdi_pcol.h
+++ b/drivers/net/ethernet/sfc/mcdi_pcol.h
@@ -274,7 +274,7 @@
* MC_CMD_WORKAROUND_BUG26807.
* May also returned for other operations such as sub-variant switching. */
#define MC_CMD_ERR_FILTERS_PRESENT 0x1014
-/* The clock whose frequency you've attempted to set set
+/* The clock whose frequency you've attempted to set
* doesn't exist on this NIC */
#define MC_CMD_ERR_NO_CLOCK 0x1015
/* Returned by MC_CMD_TESTASSERT if the action that should
@@ -7782,7 +7782,7 @@
* large number (253) it is not anticipated that this will be needed in the
* near future, so can currently be ignored.
*
- * On Riverhead this command is implemented as a a wrapper for `list` in the
+ * On Riverhead this command is implemented as a wrapper for `list` in the
* sensor_query SPHINX service.
*/
#define MC_CMD_DYNAMIC_SENSORS_LIST 0x66
@@ -7827,7 +7827,7 @@
* update is in progress, and effectively means the set of usable sensors is
* the intersection between the sets of sensors known to the driver and the MC.
*
- * On Riverhead this command is implemented as a a wrapper for
+ * On Riverhead this command is implemented as a wrapper for
* `get_descriptions` in the sensor_query SPHINX service.
*/
#define MC_CMD_DYNAMIC_SENSORS_GET_DESCRIPTIONS 0x67
@@ -7876,7 +7876,7 @@
* update is in progress, and effectively means the set of usable sensors is
* the intersection between the sets of sensors known to the driver and the MC.
*
- * On Riverhead this command is implemented as a a wrapper for `get_readings`
+ * On Riverhead this command is implemented as a wrapper for `get_readings`
* in the sensor_query SPHINX service.
*/
#define MC_CMD_DYNAMIC_SENSORS_GET_READINGS 0x68
@@ -19322,7 +19322,7 @@
* TLV_PORT_MODE_*). A superset of MC_CMD_GET_PORT_MODES_OUT/MODES that
* contains all modes implemented in firmware for a particular board. Modes
* listed in MODES are considered production modes and should be exposed in
- * userland tools. Modes listed in in ENGINEERING_MODES, but not in MODES
+ * userland tools. Modes listed in ENGINEERING_MODES, but not in MODES
* should be considered hidden (not to be exposed in userland tools) and for
* engineering use only. There are no other semantic differences and any mode
* listed in either MODES or ENGINEERING_MODES can be set on the board.
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-15 15:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 7:54 [PATCH] sfc: fix repeated words in comments Jilin Yuan
2022-09-15 15:18 ` Edward Cree
-- strict thread matches above, loose matches on Subject: below --
2022-06-25 6:12 Jilin Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).