From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Allan.Nielsen@microchip.com" <Allan.Nielsen@microchip.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"petrm@nvidia.com" <petrm@nvidia.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>
Subject: Re: [RFC PATCH v2 net-next 2/2] net: dcb: add new apptrust attribute
Date: Thu, 15 Sep 2022 09:51:46 +0000 [thread overview]
Message-ID: <20220915095145.jbqchpfiu7hyzk6a@skbuf> (raw)
In-Reply-To: <20220915095757.2861822-3-daniel.machon@microchip.com>
On Thu, Sep 15, 2022 at 11:57:57AM +0200, Daniel Machon wrote:
> + if (ops->dcbnl_getapptrust) {
> + u8 selectors[IEEE_8021QAZ_APP_SEL_MAX + 1] = {0};
> + int nselectors;
> +
> + apptrust = nla_nest_start_noflag(skb,
> + DCB_ATTR_DCB_APP_TRUST_TABLE);
> + if (!app)
> + return -EMSGSIZE;
Should new code be creating nests without the NLA_F_NESTED flag?
> +
> + err = ops->dcbnl_getapptrust(netdev, selectors, &nselectors);
> + if (err)
> + return -EMSGSIZE;
> +
> + for (i = 0; i < nselectors; i++)
> + nla_put_u8(skb, DCB_ATTR_DCB_APP_TRUST, selectors[i]);
> + nla_nest_end(skb, apptrust);
> + }
next prev parent reply other threads:[~2022-09-15 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 9:57 [RFC PATCH v2 net-next 0/2] Add PCP selector and new APPTRUST attribute Daniel Machon
2022-09-15 9:57 ` [RFC PATCH v2 net-next 1/2] net: dcb: add new pcp selector to app object Daniel Machon
2022-09-19 9:45 ` Petr Machata
2022-09-28 13:52 ` Daniel.Machon
2022-09-28 15:50 ` Petr Machata
2022-09-15 9:57 ` [RFC PATCH v2 net-next 2/2] net: dcb: add new apptrust attribute Daniel Machon
2022-09-15 9:51 ` Vladimir Oltean [this message]
2022-09-19 7:30 ` Petr Machata
2022-09-19 7:54 ` [RFC PATCH v2 net-next 0/2] Add PCP selector and new APPTRUST attribute Petr Machata
2022-09-19 8:13 ` Daniel.Machon
2022-09-19 15:11 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915095145.jbqchpfiu7hyzk6a@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=Allan.Nielsen@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).