From: Petr Machata <petrm@nvidia.com>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: <netdev@vger.kernel.org>, <Allan.Nielsen@microchip.com>,
<UNGLinuxDriver@microchip.com>, <maxime.chevallier@bootlin.com>,
<vladimir.oltean@nxp.com>, <petrm@nvidia.com>, <kuba@kernel.org>,
<vinicius.gomes@intel.com>, <thomas.petazzoni@bootlin.com>
Subject: Re: [RFC PATCH v2 net-next 1/2] net: dcb: add new pcp selector to app object
Date: Mon, 19 Sep 2022 11:45:41 +0200 [thread overview]
Message-ID: <87edw7y93y.fsf@nvidia.com> (raw)
In-Reply-To: <20220915095757.2861822-2-daniel.machon@microchip.com>
Daniel Machon <daniel.machon@microchip.com> writes:
> diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h
> index a791a94013a6..8eab16e5bc13 100644
> --- a/include/uapi/linux/dcbnl.h
> +++ b/include/uapi/linux/dcbnl.h
> @@ -217,6 +217,7 @@ struct cee_pfc {
> #define IEEE_8021QAZ_APP_SEL_DGRAM 3
> #define IEEE_8021QAZ_APP_SEL_ANY 4
> #define IEEE_8021QAZ_APP_SEL_DSCP 5
> +#define IEEE_8021QAZ_APP_SEL_PCP 255
>
> /* This structure contains the IEEE 802.1Qaz APP managed object. This
> * object is also used for the CEE std as well.
One more thought: please verify how this behaves with openlldpad.
It's a fairly major user of this API.
I guess it is OK if it refuses to run or bails out in face of the PCP
APP entries. On its own it will never introduce them, so this clear and
noisy diagnostic when a user messes with the system through a different
channels is OK IMHO.
But it shouldn't silently reinterpret the 255 to mean something else.
next prev parent reply other threads:[~2022-09-19 10:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 9:57 [RFC PATCH v2 net-next 0/2] Add PCP selector and new APPTRUST attribute Daniel Machon
2022-09-15 9:57 ` [RFC PATCH v2 net-next 1/2] net: dcb: add new pcp selector to app object Daniel Machon
2022-09-19 9:45 ` Petr Machata [this message]
2022-09-28 13:52 ` Daniel.Machon
2022-09-28 15:50 ` Petr Machata
2022-09-15 9:57 ` [RFC PATCH v2 net-next 2/2] net: dcb: add new apptrust attribute Daniel Machon
2022-09-15 9:51 ` Vladimir Oltean
2022-09-19 7:30 ` Petr Machata
2022-09-19 7:54 ` [RFC PATCH v2 net-next 0/2] Add PCP selector and new APPTRUST attribute Petr Machata
2022-09-19 8:13 ` Daniel.Machon
2022-09-19 15:11 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edw7y93y.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=Allan.Nielsen@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).