* [PATCH] net: dm9051: Fix missing dev_kfree_skb() in dm9051_loop_rx()
@ 2022-11-21 3:32 Yuan Can
2022-11-21 18:09 ` Maciej Fijalkowski
2022-11-23 12:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yuan Can @ 2022-11-21 3:32 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, sfr, error27, bigeasy,
colin.i.king, yang.lee, josright123, netdev
Cc: yuancan
The dm9051_loop_rx() returns without release skb when dm9051_stop_mrcmd()
returns error, free the skb to avoid this leak.
Fixes: 2dc95a4d30ed ("net: Add dm9051 driver")
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
drivers/net/ethernet/davicom/dm9051.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/davicom/dm9051.c b/drivers/net/ethernet/davicom/dm9051.c
index a523ddda7609..de7105a84747 100644
--- a/drivers/net/ethernet/davicom/dm9051.c
+++ b/drivers/net/ethernet/davicom/dm9051.c
@@ -798,8 +798,10 @@ static int dm9051_loop_rx(struct board_info *db)
}
ret = dm9051_stop_mrcmd(db);
- if (ret)
+ if (ret) {
+ dev_kfree_skb(skb);
return ret;
+ }
skb->protocol = eth_type_trans(skb, db->ndev);
if (db->ndev->features & NETIF_F_RXCSUM)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dm9051: Fix missing dev_kfree_skb() in dm9051_loop_rx()
2022-11-21 3:32 [PATCH] net: dm9051: Fix missing dev_kfree_skb() in dm9051_loop_rx() Yuan Can
@ 2022-11-21 18:09 ` Maciej Fijalkowski
2022-11-23 12:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Maciej Fijalkowski @ 2022-11-21 18:09 UTC (permalink / raw)
To: Yuan Can
Cc: davem, edumazet, kuba, pabeni, sfr, error27, bigeasy,
colin.i.king, yang.lee, josright123, netdev
On Mon, Nov 21, 2022 at 04:32:26AM +0100, Yuan Can wrote:
> The dm9051_loop_rx() returns without release skb when dm9051_stop_mrcmd()
> returns error, free the skb to avoid this leak.
>
> Fixes: 2dc95a4d30ed ("net: Add dm9051 driver")
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> ---
> drivers/net/ethernet/davicom/dm9051.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>
> diff --git a/drivers/net/ethernet/davicom/dm9051.c b/drivers/net/ethernet/davicom/dm9051.c
> index a523ddda7609..de7105a84747 100644
> --- a/drivers/net/ethernet/davicom/dm9051.c
> +++ b/drivers/net/ethernet/davicom/dm9051.c
> @@ -798,8 +798,10 @@ static int dm9051_loop_rx(struct board_info *db)
> }
>
> ret = dm9051_stop_mrcmd(db);
> - if (ret)
> + if (ret) {
> + dev_kfree_skb(skb);
> return ret;
> + }
>
> skb->protocol = eth_type_trans(skb, db->ndev);
> if (db->ndev->features & NETIF_F_RXCSUM)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dm9051: Fix missing dev_kfree_skb() in dm9051_loop_rx()
2022-11-21 3:32 [PATCH] net: dm9051: Fix missing dev_kfree_skb() in dm9051_loop_rx() Yuan Can
2022-11-21 18:09 ` Maciej Fijalkowski
@ 2022-11-23 12:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-23 12:50 UTC (permalink / raw)
To: Yuan Can
Cc: davem, edumazet, kuba, pabeni, sfr, error27, bigeasy,
colin.i.king, yang.lee, josright123, netdev
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 21 Nov 2022 03:32:26 +0000 you wrote:
> The dm9051_loop_rx() returns without release skb when dm9051_stop_mrcmd()
> returns error, free the skb to avoid this leak.
>
> Fixes: 2dc95a4d30ed ("net: Add dm9051 driver")
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> ---
> drivers/net/ethernet/davicom/dm9051.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Here is the summary with links:
- net: dm9051: Fix missing dev_kfree_skb() in dm9051_loop_rx()
https://git.kernel.org/netdev/net/c/bac81f40c2c1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-23 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 3:32 [PATCH] net: dm9051: Fix missing dev_kfree_skb() in dm9051_loop_rx() Yuan Can
2022-11-21 18:09 ` Maciej Fijalkowski
2022-11-23 12:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).