Re: [PATCH] can: sja1000: plx_pci: fix error handling path in plx_pci_add_card() - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Julia Lawall <julia@diku.dk>,
	Pavel Cheblakov <P.B.Cheblakov@inp.nsk.su>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: sja1000: plx_pci: fix error handling path in plx_pci_add_card()
Date: Thu, 24 Nov 2022 15:46:38 +0100	[thread overview]
Message-ID: <20221124144638.kqbmksqntn2dugal@pengutronix.de> (raw)
In-Reply-To: <1669029031-7743-1-git-send-email-zhangchangzhong@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

On 21.11.2022 19:10:30, Zhang Changzhong wrote:
> If pci_iomap() or register_sja1000dev() fails, netdev will not be
> registered, but plx_pci_del_card() still deregisters the netdev.
> 
> To avoid this, let's free the netdev and clear card->net_dev[i] before
> calling plx_pci_del_card(). In addition, add the missing pci_iounmap()
> when the channel does not exist.
> 
> Compile tested only.
> 
> Fixes: 951f2f960e5b ("drivers/net/can/sja1000/plx_pci.c: eliminate double free")
> Fixes: 24c4a3b29255 ("can: add support for CAN interface cards based on the PLX90xx PCI bridge")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
>  drivers/net/can/sja1000/plx_pci.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c
> index 5de1ebb..1158f5a 100644
> --- a/drivers/net/can/sja1000/plx_pci.c
> +++ b/drivers/net/can/sja1000/plx_pci.c
> @@ -678,6 +678,8 @@ static int plx_pci_add_card(struct pci_dev *pdev,
>  		if (!addr) {
>  			err = -ENOMEM;
>  			dev_err(&pdev->dev, "Failed to remap BAR%d\n", cm->bar);
> +			free_sja1000dev(dev);
> +			card->net_dev[i] = NULL;
>  			goto failure_cleanup;
>  		}
>  
> @@ -699,6 +701,9 @@ static int plx_pci_add_card(struct pci_dev *pdev,
>  			if (err) {
>  				dev_err(&pdev->dev, "Registering device failed "
>  					"(err=%d)\n", err);
> +				pci_iounmap(pdev, priv->reg_base);
> +				free_sja1000dev(dev);
> +				card->net_dev[i] = NULL;
>  				goto failure_cleanup;
>  			}
>  
> @@ -710,6 +715,7 @@ static int plx_pci_add_card(struct pci_dev *pdev,
>  		} else {
>  			dev_err(&pdev->dev, "Channel #%d not detected\n",
>  				i + 1);
> +			pci_iounmap(pdev, priv->reg_base);
>  			free_sja1000dev(dev);
>  			card->net_dev[i] = NULL;

There's quite some cleanup code doubling. Can you introduce a goto style
cleanup?

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]