* [PATCH] ipw2x00: Remove some unused functions
@ 2022-11-29 6:24 Jiapeng Chong
2022-12-08 14:43 ` wifi: " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-11-29 6:24 UTC (permalink / raw)
To: stas.yakovlev
Cc: kvalo, davem, edumazet, kuba, pabeni, linux-wireless, netdev,
linux-kernel, Jiapeng Chong, Abaci Robot
Functions write_nic_auto_inc_address() and write_nic_dword_auto_inc() are
defined in the ipw2100.c file, but not called elsewhere, so remove these
unused functions.
drivers/net/wireless/intel/ipw2x00/ipw2100.c:427:20: warning: unused function 'write_nic_dword_auto_inc'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3285
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/wireless/intel/ipw2x00/ipw2100.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index b0f23cf1a621..0812db8936f1 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -418,17 +418,6 @@ static inline void write_nic_byte(struct net_device *dev, u32 addr, u8 val)
write_register_byte(dev, IPW_REG_INDIRECT_ACCESS_DATA, val);
}
-static inline void write_nic_auto_inc_address(struct net_device *dev, u32 addr)
-{
- write_register(dev, IPW_REG_AUTOINCREMENT_ADDRESS,
- addr & IPW_REG_INDIRECT_ADDR_MASK);
-}
-
-static inline void write_nic_dword_auto_inc(struct net_device *dev, u32 val)
-{
- write_register(dev, IPW_REG_AUTOINCREMENT_DATA, val);
-}
-
static void write_nic_memory(struct net_device *dev, u32 addr, u32 len,
const u8 * buf)
{
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: wifi: ipw2x00: Remove some unused functions
2022-11-29 6:24 [PATCH] ipw2x00: Remove some unused functions Jiapeng Chong
@ 2022-12-08 14:43 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-12-08 14:43 UTC (permalink / raw)
To: Jiapeng Chong
Cc: stas.yakovlev, davem, edumazet, kuba, pabeni, linux-wireless,
netdev, linux-kernel, Jiapeng Chong, Abaci Robot
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Functions write_nic_auto_inc_address() and write_nic_dword_auto_inc() are
> defined in the ipw2100.c file, but not called elsewhere, so remove these
> unused functions.
>
> drivers/net/wireless/intel/ipw2x00/ipw2100.c:427:20: warning: unused function 'write_nic_dword_auto_inc'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3285
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Patch applied to wireless-next.git, thanks.
5107778d0061 wifi: ipw2x00: Remove some unused functions
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221129062407.83157-1-jiapeng.chong@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-08 14:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-29 6:24 [PATCH] ipw2x00: Remove some unused functions Jiapeng Chong
2022-12-08 14:43 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).