* [PATCH net-next v3] net: phy: mxl-gpy: fix delay time required by loopback disable function
@ 2023-01-11 8:22 Xu Liang
2023-01-11 13:40 ` Andrew Lunn
2023-01-13 5:30 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Xu Liang @ 2023-01-11 8:22 UTC (permalink / raw)
To: andrew, hkallweit1, netdev, davem, kuba
Cc: linux, hmehrtens, tmohren, mohammad.athari.ismail, edumazet,
michael, pabeni, Xu Liang
GPY2xx devices need 3 seconds to fully switch out of loopback mode
before it can safely re-enter loopback mode.
Signed-off-by: Xu Liang <lxu@maxlinear.com>
---
v2 changes:
Update comments.
v3 changes:
Submit for net-next.
drivers/net/phy/mxl-gpy.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
index 147d7a5a9b35..b682d7fc477c 100644
--- a/drivers/net/phy/mxl-gpy.c
+++ b/drivers/net/phy/mxl-gpy.c
@@ -770,9 +770,11 @@ static int gpy_loopback(struct phy_device *phydev, bool enable)
enable ? BMCR_LOOPBACK : 0);
if (!ret) {
/* It takes some time for PHY device to switch
- * into/out-of loopback mode.
+ * into/out-of loopback mode. It takes 3 seconds
+ * to fully switch out of loopback mode before
+ * it can safely re-enter loopback mode.
*/
- msleep(100);
+ msleep(enable ? 100 : 3000);
}
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3] net: phy: mxl-gpy: fix delay time required by loopback disable function
2023-01-11 8:22 [PATCH net-next v3] net: phy: mxl-gpy: fix delay time required by loopback disable function Xu Liang
@ 2023-01-11 13:40 ` Andrew Lunn
2023-01-13 5:30 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2023-01-11 13:40 UTC (permalink / raw)
To: Xu Liang
Cc: hkallweit1, netdev, davem, kuba, linux, hmehrtens, tmohren,
mohammad.athari.ismail, edumazet, michael, pabeni
On Wed, Jan 11, 2023 at 04:22:01PM +0800, Xu Liang wrote:
> GPY2xx devices need 3 seconds to fully switch out of loopback mode
> before it can safely re-enter loopback mode.
>
> Signed-off-by: Xu Liang <lxu@maxlinear.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3] net: phy: mxl-gpy: fix delay time required by loopback disable function
2023-01-11 8:22 [PATCH net-next v3] net: phy: mxl-gpy: fix delay time required by loopback disable function Xu Liang
2023-01-11 13:40 ` Andrew Lunn
@ 2023-01-13 5:30 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-01-13 5:30 UTC (permalink / raw)
To: Xu Liang
Cc: andrew, hkallweit1, netdev, davem, linux, hmehrtens, tmohren,
mohammad.athari.ismail, edumazet, michael, pabeni
On Wed, 11 Jan 2023 16:22:01 +0800 Xu Liang wrote:
> GPY2xx devices need 3 seconds to fully switch out of loopback mode
> before it can safely re-enter loopback mode.
>
> Signed-off-by: Xu Liang <lxu@maxlinear.com>
Looks like a fix, it needs a Fixes tag and needs to go to net.
Michael already asked you for the Fixes tag on v2, why did you decide
to switch to net-next instead?
We don't route fixes to net-next when they are targeting less
important features, in case that's your reason. Either something
is a fix or it's not. If you think this is not a fix - you need to
explain in the commit message why.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-13 5:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-11 8:22 [PATCH net-next v3] net: phy: mxl-gpy: fix delay time required by loopback disable function Xu Liang
2023-01-11 13:40 ` Andrew Lunn
2023-01-13 5:30 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).