Re: [Intel-wired-lan] [PATCH 1/1] ice: Add the CEE DCBX support in the comments

Re: [Intel-wired-lan] [PATCH 1/1] ice: Add the CEE DCBX support in the comments

[Paul Menzel]

Dear Zhu,


Thank you for your patch. (Unfortunately your system time is incorrect, 
so the message date is from the future.)

Am 14.01.23 um 00:19 schrieb Zhu Yanjun:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>

Maybe use the following summary/title/subject:

ice: Mention CEE DCBX in code comment

> From the function ice_parse_org_tlv, CEE DCBX TLV is also supported.
> The comments are changed.

…, so update the comment.

> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
>   drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

The rest looks good.

[…]


Kind regards,

Paul

[PATCH 1/1] ice: Add the CEE DCBX support in the comments

[Zhu Yanjun]

From: Zhu Yanjun <yanjun.zhu@linux.dev>

From the function ice_parse_org_tlv, CEE DCBX TLV is also supported.
The comments are changed.

Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
 drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
index 6be02f9b0b8c..7964405efa77 100644
--- a/drivers/net/ethernet/intel/ice/ice_dcb.c
+++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
@@ -566,7 +566,7 @@ ice_parse_cee_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
  * @tlv: Organization specific TLV
  * @dcbcfg: Local store to update ETS REC data
  *
- * Currently only IEEE 802.1Qaz TLV is supported, all others
+ * Currently IEEE 802.1Qaz and CEE DCBX TLV are supported, others
  * will be returned
  */
 static void
@@ -585,7 +585,7 @@ ice_parse_org_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
 		ice_parse_cee_tlv(tlv, dcbcfg);
 		break;
 	default:
-		break;
+		break; /* Other OUIs not supported */
 	}
 }
 
-- 
2.27.0