From: Rob Herring <robh@kernel.org>
To: Gatien Chevallier <gatien.chevallier@foss.st.com>
Cc: Oleksii_Moisieiev@epam.com, gregkh@linuxfoundation.org,
herbert@gondor.apana.org.au, davem@davemloft.net,
krzysztof.kozlowski+dt@linaro.org, alexandre.torgue@foss.st.com,
vkoul@kernel.org, jic23@kernel.org, olivier.moysan@foss.st.com,
arnaud.pouliquen@foss.st.com, mchehab@kernel.org,
fabrice.gasnier@foss.st.com, ulf.hansson@linaro.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org,
alsa-devel@alsa-project.org, linux-media@vger.kernel.org,
linux-mmc@vger.kernel.org, netdev@vger.kernel.org,
linux-phy@lists.infradead.org, linux-serial@vger.kernel.org,
linux-spi@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 2/6] dt-bindings: treewide: add feature-domains description in binding files
Date: Fri, 3 Feb 2023 14:57:48 -0600 [thread overview]
Message-ID: <20230203205748.GA860175-robh@kernel.org> (raw)
In-Reply-To: <20230127164040.1047583-3-gatien.chevallier@foss.st.com>
On Fri, Jan 27, 2023 at 05:40:36PM +0100, Gatien Chevallier wrote:
> feature-domains is an optional property that allows a peripheral to
> refer to one or more feature domain controller(s).
>
> Description of this property is added to all peripheral binding files of
> the peripheral under the STM32 System Bus. It allows an accurate
> representation of the hardware, where various peripherals are connected
> to this firewall bus. The firewall can then check the peripheral accesses
> before allowing it to probe.
>
> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
> ---
>
> Patch not present in V1 and V2.
>
> Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml | 5 +++++
> Documentation/devicetree/bindings/dma/st,stm32-dma.yaml | 5 +++++
> Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml | 5 +++++
> Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 5 +++++
> Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 5 +++++
> .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 5 +++++
> Documentation/devicetree/bindings/iio/dac/st,stm32-dac.yaml | 5 +++++
> Documentation/devicetree/bindings/media/st,stm32-cec.yaml | 5 +++++
> Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 5 +++++
> .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 5 +++++
> Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml | 5 +++++
> Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml | 6 ++++++
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 5 +++++
> Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 5 +++++
> .../devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 5 +++++
> .../devicetree/bindings/regulator/st,stm32-vrefbuf.yaml | 5 +++++
> Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 5 +++++
> Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++
> Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++
> Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 5 +++++
> .../devicetree/bindings/sound/st,stm32-spdifrx.yaml | 5 +++++
> Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml | 5 +++++
> Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 5 +++++
> Documentation/devicetree/bindings/usb/dwc2.yaml | 5 +++++
> 24 files changed, 121 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml
> index 4ccb335e8063..cb2ad7d5fdb5 100644
> --- a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml
> +++ b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml
> @@ -41,6 +41,11 @@ properties:
> maximum: 2
> default: 0
>
> + feature-domains:
> + $ref: /schemas/feature-controllers/feature-domain-controller.yaml#/properties/feature-domains
Not how common properties work. Consumer properties should be in a
schema with 'select: true' (the one you are referencing) and here you
just need to define the entries. Like clocks, power-domains, etc.
> + minItems: 1
> + maxItems: 3
Why is this variable and what is each entry?
I still don't like the naming. Everything is a feature and a domain...
It might be a bit easier to come up with a name with multiple users of
this binding presented. I'm hesistant to define any new common binding
with only 1 user as I've said multiple times on this binding.
Rob
next prev parent reply other threads:[~2023-02-03 20:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 16:40 [PATCH v3 0/6] Introduce STM32 system bus Gatien Chevallier
2023-01-27 16:40 ` [PATCH v3 1/6] dt-bindings: Document common device controller bindings Gatien Chevallier
2023-01-27 16:49 ` Krzysztof Kozlowski
2023-01-27 17:00 ` Gatien CHEVALLIER
2023-01-27 16:40 ` [PATCH v3 2/6] dt-bindings: treewide: add feature-domains description in binding files Gatien Chevallier
2023-01-28 15:46 ` Jonathan Cameron
2023-02-03 20:57 ` Rob Herring [this message]
2023-01-27 16:40 ` [PATCH v3 3/6] dt-bindings: bus: add STM32 System Bus Gatien Chevallier
2023-01-28 15:48 ` Jonathan Cameron
2023-02-07 13:31 ` Gatien CHEVALLIER
2023-01-27 16:40 ` [PATCH v3 4/6] bus: stm32_sys_bus: add support for STM32MP15 and STM32MP13 system bus Gatien Chevallier
2023-01-28 16:12 ` Jonathan Cameron
2023-02-07 14:12 ` Gatien CHEVALLIER
2023-02-08 19:08 ` Jonathan Cameron
2023-01-27 16:40 ` [PATCH v3 5/6] ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards Gatien Chevallier
2023-02-09 7:51 ` Uwe Kleine-König
2023-01-27 16:40 ` [PATCH v3 6/6] ARM: dts: stm32: add ETZPC as a system bus for STM32MP13x boards Gatien Chevallier
2023-02-09 7:46 ` [Linux-stm32] " Ahmad Fatoum
2023-02-09 8:10 ` Ahmad Fatoum
2023-02-13 10:54 ` Gatien CHEVALLIER
2023-02-13 11:27 ` Ahmad Fatoum
2023-02-27 11:26 ` Gatien CHEVALLIER
2023-04-21 10:19 ` Oleksii Moisieiev
2023-04-25 7:56 ` Gatien CHEVALLIER
2023-07-05 17:35 ` [PATCH v3 0/6] Introduce STM32 system bus Gatien CHEVALLIER
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203205748.GA860175-robh@kernel.org \
--to=robh@kernel.org \
--cc=Oleksii_Moisieiev@epam.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=gatien.chevallier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier.moysan@foss.st.com \
--cc=pabeni@redhat.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).