From: Gatien CHEVALLIER <gatien.chevallier@foss.st.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: <Oleksii_Moisieiev@epam.com>, <gregkh@linuxfoundation.org>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<alexandre.torgue@foss.st.com>, <vkoul@kernel.org>,
<olivier.moysan@foss.st.com>, <arnaud.pouliquen@foss.st.com>,
<mchehab@kernel.org>, <fabrice.gasnier@foss.st.com>,
<ulf.hansson@linaro.org>, <edumazet@google.com>,
<kuba@kernel.org>, <pabeni@redhat.com>,
<linux-crypto@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <dmaengine@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<alsa-devel@alsa-project.org>, <linux-media@vger.kernel.org>,
<linux-mmc@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-phy@lists.infradead.org>, <linux-serial@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <linux-usb@vger.kernel.org>,
Loic PALLARDY <loic.pallardy@st.com>
Subject: Re: [PATCH v3 3/6] dt-bindings: bus: add STM32 System Bus
Date: Tue, 7 Feb 2023 14:31:18 +0100 [thread overview]
Message-ID: <d283ef50-7807-b928-83a5-63ef4565f9e4@foss.st.com> (raw)
In-Reply-To: <20230128154827.4f23534e@jic23-huawei>
Hello Jonathan,
On 1/28/23 16:48, Jonathan Cameron wrote:
> On Fri, 27 Jan 2023 17:40:37 +0100
> Gatien Chevallier <gatien.chevallier@foss.st.com> wrote:
>
>> Document STM32 System Bus. This bus is intended to control firewall
>> access for the peripherals connected to it.
>>
>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>> Signed-off-by: Loic PALLARDY <loic.pallardy@st.com>
> Trivial comment on formatting.
>
>> +
>> +examples:
>> + - |
>> + // In this example, the rng1 device refers to etzpc as its domain controller.
>> + // Same goes for fmc.
>> + // Access rights are verified before creating devices.
>> +
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/clock/stm32mp1-clks.h>
>> + #include <dt-bindings/reset/stm32mp1-resets.h>
>> +
>> + etzpc: bus@5c007000 {
>> + compatible = "st,stm32mp15-sys-bus";
>> + reg = <0x5c007000 0x400>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> + feature-domain-controller;
>> + #feature-domain-cells = <1>;
>> +
>> + rng1: rng@54003000 {
>
> Odd mixture of 4 spacing and 2 spacing in this example.
> I'd suggest one or the other (slight preference for 4 space indents).
>
Thank you for spotting this, I'll change to 4 space indents
>
>> + compatible = "st,stm32-rng";
>> + reg = <0x54003000 0x400>;
>> + clocks = <&rcc RNG1_K>;
>> + resets = <&rcc RNG1_R>;
>> + feature-domains = <&etzpc 7>;
>> + status = "disabled";
>> + };
Best regards,
Gatien
next prev parent reply other threads:[~2023-02-07 13:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 16:40 [PATCH v3 0/6] Introduce STM32 system bus Gatien Chevallier
2023-01-27 16:40 ` [PATCH v3 1/6] dt-bindings: Document common device controller bindings Gatien Chevallier
2023-01-27 16:49 ` Krzysztof Kozlowski
2023-01-27 17:00 ` Gatien CHEVALLIER
2023-01-27 16:40 ` [PATCH v3 2/6] dt-bindings: treewide: add feature-domains description in binding files Gatien Chevallier
2023-01-28 15:46 ` Jonathan Cameron
2023-02-03 20:57 ` Rob Herring
2023-01-27 16:40 ` [PATCH v3 3/6] dt-bindings: bus: add STM32 System Bus Gatien Chevallier
2023-01-28 15:48 ` Jonathan Cameron
2023-02-07 13:31 ` Gatien CHEVALLIER [this message]
2023-01-27 16:40 ` [PATCH v3 4/6] bus: stm32_sys_bus: add support for STM32MP15 and STM32MP13 system bus Gatien Chevallier
2023-01-28 16:12 ` Jonathan Cameron
2023-02-07 14:12 ` Gatien CHEVALLIER
2023-02-08 19:08 ` Jonathan Cameron
2023-01-27 16:40 ` [PATCH v3 5/6] ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards Gatien Chevallier
2023-02-09 7:51 ` Uwe Kleine-König
2023-01-27 16:40 ` [PATCH v3 6/6] ARM: dts: stm32: add ETZPC as a system bus for STM32MP13x boards Gatien Chevallier
2023-02-09 7:46 ` [Linux-stm32] " Ahmad Fatoum
2023-02-09 8:10 ` Ahmad Fatoum
2023-02-13 10:54 ` Gatien CHEVALLIER
2023-02-13 11:27 ` Ahmad Fatoum
2023-02-27 11:26 ` Gatien CHEVALLIER
2023-04-21 10:19 ` Oleksii Moisieiev
2023-04-25 7:56 ` Gatien CHEVALLIER
2023-07-05 17:35 ` [PATCH v3 0/6] Introduce STM32 system bus Gatien CHEVALLIER
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d283ef50-7807-b928-83a5-63ef4565f9e4@foss.st.com \
--to=gatien.chevallier@foss.st.com \
--cc=Oleksii_Moisieiev@epam.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier.moysan@foss.st.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).