netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tools: ynl: Remove duplicate include
@ 2023-06-08  9:28 Jiapeng Chong
  0 siblings, 0 replies; 3+ messages in thread
From: Jiapeng Chong @ 2023-06-08  9:28 UTC (permalink / raw)
  To: davem
  Cc: edumazet, kuba, pabeni, netdev, linux-kernel, Jiapeng Chong, Abaci Robot

./tools/net/ynl/generated/fou-user.c: stdlib.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5467
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 tools/net/ynl/generated/fou-user.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/net/ynl/generated/fou-user.c b/tools/net/ynl/generated/fou-user.c
index c99b5d438021..2c19ee68000a 100644
--- a/tools/net/ynl/generated/fou-user.c
+++ b/tools/net/ynl/generated/fou-user.c
@@ -8,7 +8,6 @@
 #include "ynl.h"
 #include <linux/fou.h>
 
-#include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
 #include <libmnl/libmnl.h>
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools: ynl: Remove duplicate include
  2023-06-08  9:30 Jiapeng Chong
@ 2023-06-08 11:46 ` Simon Horman
  0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-06-08 11:46 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: davem, edumazet, kuba, pabeni, ast, daniel, hawk, john.fastabend,
	netdev, linux-kernel, bpf, Abaci Robot

On Thu, Jun 08, 2023 at 05:30:36PM +0800, Jiapeng Chong wrote:
> ./tools/net/ynl/generated/netdev-user.c: stdlib.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5466
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  tools/net/ynl/generated/netdev-user.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/net/ynl/generated/netdev-user.c b/tools/net/ynl/generated/netdev-user.c
> index aea5c7cc8ead..1883a658180b 100644
> --- a/tools/net/ynl/generated/netdev-user.c
> +++ b/tools/net/ynl/generated/netdev-user.c
> @@ -8,7 +8,6 @@
>  #include "ynl.h"
>  #include <linux/netdev.h>
>  
> -#include <stdlib.h>
>  #include <stdio.h>
>  #include <string.h>
>  #include <libmnl/libmnl.h>

This duplicates:

- [PATCH -next] tools: ynl: Remove duplicated include in handshake-user.c
  https://lore.kernel.org/all/20230608083148.5514-1-yang.lee@linux.alibaba.com/

So lets focus on that one.

In all three very similar patches were sent in a short space of time.
It's better not to do that.

-- 
pw-bot: reject



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] tools: ynl: Remove duplicate include
@ 2023-06-08  9:30 Jiapeng Chong
  2023-06-08 11:46 ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Chong @ 2023-06-08  9:30 UTC (permalink / raw)
  To: davem
  Cc: edumazet, kuba, pabeni, ast, daniel, hawk, john.fastabend,
	netdev, linux-kernel, bpf, Jiapeng Chong, Abaci Robot

./tools/net/ynl/generated/netdev-user.c: stdlib.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5466
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 tools/net/ynl/generated/netdev-user.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/net/ynl/generated/netdev-user.c b/tools/net/ynl/generated/netdev-user.c
index aea5c7cc8ead..1883a658180b 100644
--- a/tools/net/ynl/generated/netdev-user.c
+++ b/tools/net/ynl/generated/netdev-user.c
@@ -8,7 +8,6 @@
 #include "ynl.h"
 #include <linux/netdev.h>
 
-#include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
 #include <libmnl/libmnl.h>
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-08 11:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-08  9:28 [PATCH] tools: ynl: Remove duplicate include Jiapeng Chong
2023-06-08  9:30 Jiapeng Chong
2023-06-08 11:46 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).