* [PATCH iwl-next] ice: use ice_down_up() where applicable
@ 2023-06-12 14:17 Maciej Fijalkowski
2023-06-13 10:25 ` [Intel-wired-lan] " Przemek Kitszel
0 siblings, 1 reply; 3+ messages in thread
From: Maciej Fijalkowski @ 2023-06-12 14:17 UTC (permalink / raw)
To: intel-wired-lan
Cc: netdev, anthony.l.nguyen, magnus.karlsson, Maciej Fijalkowski
ice_change_mtu() is currently using a separate ice_down() and ice_up()
calls to reflect changed MTU. ice_down_up() serves this purpose, so do
the refactoring here.
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
drivers/net/ethernet/intel/ice/ice_main.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index a1f7c8edc22f..609df077c314 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -7634,17 +7634,9 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)
/* if VSI is up, bring it down and then back up */
if (!test_and_set_bit(ICE_VSI_DOWN, vsi->state)) {
- err = ice_down(vsi);
- if (err) {
- netdev_err(netdev, "change MTU if_down err %d\n", err);
- return err;
- }
-
- err = ice_up(vsi);
- if (err) {
- netdev_err(netdev, "change MTU if_up err %d\n", err);
+ err = ice_down_up(vsi);
+ if (err)
return err;
- }
}
netdev_dbg(netdev, "changed MTU to %d\n", new_mtu);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next] ice: use ice_down_up() where applicable
2023-06-12 14:17 [PATCH iwl-next] ice: use ice_down_up() where applicable Maciej Fijalkowski
@ 2023-06-13 10:25 ` Przemek Kitszel
2023-06-13 10:43 ` Maciej Fijalkowski
0 siblings, 1 reply; 3+ messages in thread
From: Przemek Kitszel @ 2023-06-13 10:25 UTC (permalink / raw)
To: Maciej Fijalkowski, intel-wired-lan
Cc: netdev, anthony.l.nguyen, magnus.karlsson
On 6/12/23 16:17, Maciej Fijalkowski wrote:
> ice_change_mtu() is currently using a separate ice_down() and ice_up()
> calls to reflect changed MTU. ice_down_up() serves this purpose, so do
> the refactoring here.
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index a1f7c8edc22f..609df077c314 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -7634,17 +7634,9 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)
>
> /* if VSI is up, bring it down and then back up */
> if (!test_and_set_bit(ICE_VSI_DOWN, vsi->state)) {
I would remove the above if(), as ice_down_up() starts with:
if (test_and_set_bit(ICE_VSI_DOWN, vsi->state))
return 0;
which, with your change applied would just return 0.
> - err = ice_down(vsi);
> - if (err) {
> - netdev_err(netdev, "change MTU if_down err %d\n", err);
> - return err;
> - }
> -
> - err = ice_up(vsi);
> - if (err) {
> - netdev_err(netdev, "change MTU if_up err %d\n", err);
> + err = ice_down_up(vsi);
> + if (err)
> return err;
> - }
> }
>
> netdev_dbg(netdev, "changed MTU to %d\n", new_mtu);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next] ice: use ice_down_up() where applicable
2023-06-13 10:25 ` [Intel-wired-lan] " Przemek Kitszel
@ 2023-06-13 10:43 ` Maciej Fijalkowski
0 siblings, 0 replies; 3+ messages in thread
From: Maciej Fijalkowski @ 2023-06-13 10:43 UTC (permalink / raw)
To: Przemek Kitszel
Cc: intel-wired-lan, netdev, anthony.l.nguyen, magnus.karlsson
On Tue, Jun 13, 2023 at 12:25:08PM +0200, Przemek Kitszel wrote:
> On 6/12/23 16:17, Maciej Fijalkowski wrote:
> > ice_change_mtu() is currently using a separate ice_down() and ice_up()
> > calls to reflect changed MTU. ice_down_up() serves this purpose, so do
> > the refactoring here.
> >
> > Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> > ---
> > drivers/net/ethernet/intel/ice/ice_main.c | 12 ++----------
> > 1 file changed, 2 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> > index a1f7c8edc22f..609df077c314 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_main.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> > @@ -7634,17 +7634,9 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)
> > /* if VSI is up, bring it down and then back up */
> > if (!test_and_set_bit(ICE_VSI_DOWN, vsi->state)) {
>
> I would remove the above if(), as ice_down_up() starts with:
> if (test_and_set_bit(ICE_VSI_DOWN, vsi->state))
> return 0;
>
> which, with your change applied would just return 0.
Yes, thanks a lot for paying attention, sending v2 shortly.
>
>
> > - err = ice_down(vsi);
> > - if (err) {
> > - netdev_err(netdev, "change MTU if_down err %d\n", err);
> > - return err;
> > - }
> > -
> > - err = ice_up(vsi);
> > - if (err) {
> > - netdev_err(netdev, "change MTU if_up err %d\n", err);
> > + err = ice_down_up(vsi);
> > + if (err)
> > return err;
> > - }
> > }
> > netdev_dbg(netdev, "changed MTU to %d\n", new_mtu);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-13 10:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-12 14:17 [PATCH iwl-next] ice: use ice_down_up() where applicable Maciej Fijalkowski
2023-06-13 10:25 ` [Intel-wired-lan] " Przemek Kitszel
2023-06-13 10:43 ` Maciej Fijalkowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).