netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/e1000: Fix single statement blocks warning
@ 2023-06-11 22:21 Tree Davies
  2023-06-12 22:05 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Tree Davies @ 2023-06-11 22:21 UTC (permalink / raw)
  To: anthony.l.nguyen, davem, edumazet, kuba, pabeni
  Cc: tdavies, intel-wired-lan, netdev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-net-e1000-Fix-single-statement-blocks-warning.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]

From e92897ab5e93b8827d1654a0171bc53ab478ce49 Mon Sep 17 00:00:00 2001
From: Tree Davies <tdavies@darkphysics.net>
Date: Sun, 11 Jun 2023 14:41:31 -0700
Subject: [PATCH] net/e1000: Fix single statement blocks warning

This patch fixes checkpatch.pl warning of type:
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/net/ethernet/intel/e1000/e1000_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index da6e303ad99b..accc2bd7c35c 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -259,9 +259,8 @@ static int e1000_request_irq(struct e1000_adapter *adapter)
 
 	err = request_irq(adapter->pdev->irq, handler, irq_flags, netdev->name,
 			  netdev);
-	if (err) {
+	if (err)
 		e_err(probe, "Unable to allocate interrupt Error: %d\n", err);
-	}
 
 	return err;
 }
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/e1000: Fix single statement blocks warning
  2023-06-11 22:21 [PATCH] net/e1000: Fix single statement blocks warning Tree Davies
@ 2023-06-12 22:05 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2023-06-12 22:05 UTC (permalink / raw)
  To: Tree Davies
  Cc: anthony.l.nguyen, davem, edumazet, pabeni, intel-wired-lan,
	netdev, linux-kernel

On Sun, 11 Jun 2023 15:21:36 -0700 Tree Davies wrote:
> This patch fixes checkpatch.pl warning of type:
> WARNING: braces {} are not necessary for single statement blocks

We don't accept pure checkpatch "fixes" in networking, sorry.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-12 22:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-11 22:21 [PATCH] net/e1000: Fix single statement blocks warning Tree Davies
2023-06-12 22:05 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).