* [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out
@ 2023-07-18 9:09 Eugen Hristev
2023-07-18 9:34 ` Sebastian Reichel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eugen Hristev @ 2023-07-18 9:09 UTC (permalink / raw)
To: linux-kernel, linux-rockchip, linux-arm-kernel, devicetree, netdev
Cc: david.wu, heiko, krzysztof.kozlowski+dt, kernel, Eugen Hristev
'clock_in_out' property is optional, and it can be one of two enums.
The binding does not specify what is the behavior when the property is
missing altogether.
Hence, add a default value that the driver can use.
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
index 176ea5f90251..bb943c96c196 100644
--- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
@@ -80,6 +80,7 @@ properties:
"output" means GMAC provides the reference clock.
$ref: /schemas/types.yaml#/definitions/string
enum: [input, output]
+ default: input
rockchip,grf:
description: The phandle of the syscon node for the general register file.
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out
2023-07-18 9:09 [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out Eugen Hristev
@ 2023-07-18 9:34 ` Sebastian Reichel
2023-07-19 21:17 ` Rob Herring
2023-07-20 4:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2023-07-18 9:34 UTC (permalink / raw)
To: Eugen Hristev
Cc: linux-kernel, linux-rockchip, linux-arm-kernel, devicetree,
netdev, david.wu, heiko, krzysztof.kozlowski+dt, kernel
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
Hi,
On Tue, Jul 18, 2023 at 12:09:14PM +0300, Eugen Hristev wrote:
> 'clock_in_out' property is optional, and it can be one of two enums.
> The binding does not specify what is the behavior when the property is
> missing altogether.
> Hence, add a default value that the driver can use.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index 176ea5f90251..bb943c96c196 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -80,6 +80,7 @@ properties:
> "output" means GMAC provides the reference clock.
> $ref: /schemas/types.yaml#/definitions/string
> enum: [input, output]
> + default: input
>
> rockchip,grf:
> description: The phandle of the syscon node for the general register file.
> --
> 2.34.1
>
>
> --
> To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out
2023-07-18 9:09 [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out Eugen Hristev
2023-07-18 9:34 ` Sebastian Reichel
@ 2023-07-19 21:17 ` Rob Herring
2023-07-20 4:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-07-19 21:17 UTC (permalink / raw)
To: Eugen Hristev
Cc: netdev, linux-arm-kernel, devicetree, krzysztof.kozlowski+dt,
david.wu, heiko, kernel, linux-kernel, linux-rockchip
On Tue, 18 Jul 2023 12:09:14 +0300, Eugen Hristev wrote:
> 'clock_in_out' property is optional, and it can be one of two enums.
> The binding does not specify what is the behavior when the property is
> missing altogether.
> Hence, add a default value that the driver can use.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> ---
> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out
2023-07-18 9:09 [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out Eugen Hristev
2023-07-18 9:34 ` Sebastian Reichel
2023-07-19 21:17 ` Rob Herring
@ 2023-07-20 4:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-20 4:00 UTC (permalink / raw)
To: Eugen Hristev
Cc: linux-kernel, linux-rockchip, linux-arm-kernel, devicetree,
netdev, david.wu, heiko, krzysztof.kozlowski+dt, kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 18 Jul 2023 12:09:14 +0300 you wrote:
> 'clock_in_out' property is optional, and it can be one of two enums.
> The binding does not specify what is the behavior when the property is
> missing altogether.
> Hence, add a default value that the driver can use.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
>
> [...]
Here is the summary with links:
- dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out
https://git.kernel.org/netdev/net-next/c/51318bf44395
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-20 4:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-18 9:09 [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out Eugen Hristev
2023-07-18 9:34 ` Sebastian Reichel
2023-07-19 21:17 ` Rob Herring
2023-07-20 4:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).