* [PATCH] ethernet: wiznet: Use devm_platform_get_and_ioremap_resource() in w5300_hw_probe()
@ 2024-02-05 13:28 Markus Elfring
2024-02-09 21:41 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2024-02-05 13:28 UTC (permalink / raw)
To: netdev, kernel-janitors, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Uwe Kleine-König
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 5 Feb 2024 14:22:32 +0100
A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/ethernet/wiznet/w5300.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c
index 3318b50a5911..f165616f36fe 100644
--- a/drivers/net/ethernet/wiznet/w5300.c
+++ b/drivers/net/ethernet/wiznet/w5300.c
@@ -539,8 +539,7 @@ static int w5300_hw_probe(struct platform_device *pdev)
eth_hw_addr_random(ndev);
}
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(&pdev->dev, mem);
+ priv->base = devm_platform_get_and_ioremap_resource(pdev, 0, &mem);
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ethernet: wiznet: Use devm_platform_get_and_ioremap_resource() in w5300_hw_probe()
2024-02-05 13:28 [PATCH] ethernet: wiznet: Use devm_platform_get_and_ioremap_resource() in w5300_hw_probe() Markus Elfring
@ 2024-02-09 21:41 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2024-02-09 21:41 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, kernel-janitors, David S. Miller, Eric Dumazet,
Paolo Abeni, Uwe Kleine-König, LKML
On Mon, 5 Feb 2024 14:28:17 +0100 Markus Elfring wrote:
> A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source code.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-09 21:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-05 13:28 [PATCH] ethernet: wiznet: Use devm_platform_get_and_ioremap_resource() in w5300_hw_probe() Markus Elfring
2024-02-09 21:41 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).