* [PATCH] net/ibmvnic: Fix typo in retry check
@ 2019-12-11 15:32 Thomas Falcon
2019-12-11 15:34 ` Thomas Falcon
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Falcon @ 2019-12-11 15:32 UTC (permalink / raw)
To: netdev; +Cc: linuxppc-dev, Thomas Falcon
This conditional is missing a bang, with the intent
being to break when the retry count reaches zero.
Fixes: 476d96ca9c ("ibmvnic: Bound waits for device queries")
Suggested-by: Juliet Kim <minkim@linux.ibm.com>
Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index efb0f10..2d84523 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -184,7 +184,7 @@ static int ibmvnic_wait_for_completion(struct ibmvnic_adapter *adapter,
netdev_err(netdev, "Device down!\n");
return -ENODEV;
}
- if (retry--)
+ if (!retry--)
break;
if (wait_for_completion_timeout(comp_done, div_timeout))
return 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/ibmvnic: Fix typo in retry check
2019-12-11 15:32 [PATCH] net/ibmvnic: Fix typo in retry check Thomas Falcon
@ 2019-12-11 15:34 ` Thomas Falcon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Falcon @ 2019-12-11 15:34 UTC (permalink / raw)
To: netdev; +Cc: linuxppc-dev
On 12/11/19 9:32 AM, Thomas Falcon wrote:
> This conditional is missing a bang, with the intent
> being to break when the retry count reaches zero.
>
> Fixes: 476d96ca9c ("ibmvnic: Bound waits for device queries")
> Suggested-by: Juliet Kim <minkim@linux.ibm.com>
> Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
> ---
Excuse me, disregard this patch. I used the wrong email address for
Juliet. And forgot the intended branch. I will resend a v2 soon.
Tom
> drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index efb0f10..2d84523 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -184,7 +184,7 @@ static int ibmvnic_wait_for_completion(struct ibmvnic_adapter *adapter,
> netdev_err(netdev, "Device down!\n");
> return -ENODEV;
> }
> - if (retry--)
> + if (!retry--)
> break;
> if (wait_for_completion_timeout(comp_done, div_timeout))
> return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-11 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 15:32 [PATCH] net/ibmvnic: Fix typo in retry check Thomas Falcon
2019-12-11 15:34 ` Thomas Falcon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).