* [PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code
@ 2019-09-29 8:32 Joakim Zhang
2019-09-30 5:53 ` Sean Nyekjaer
2019-10-04 21:10 ` Marc Kleine-Budde
0 siblings, 2 replies; 3+ messages in thread
From: Joakim Zhang @ 2019-09-29 8:32 UTC (permalink / raw)
To: mkl, linux-can; +Cc: wg, netdev, sean, dl-linux-imx, Joakim Zhang
Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together to simplify
the code.
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
drivers/net/can/flexcan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index b3edaf6a5a61..3cfa6037f03c 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -1507,7 +1507,6 @@ static int flexcan_probe(struct platform_device *pdev)
struct net_device *dev;
struct flexcan_priv *priv;
struct regulator *reg_xceiver;
- struct resource *mem;
struct clk *clk_ipg = NULL, *clk_per = NULL;
struct flexcan_regs __iomem *regs;
int err, irq;
@@ -1538,12 +1537,11 @@ static int flexcan_probe(struct platform_device *pdev)
clock_freq = clk_get_rate(clk_per);
}
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
irq = platform_get_irq(pdev, 0);
if (irq <= 0)
return -ENODEV;
- regs = devm_ioremap_resource(&pdev->dev, mem);
+ regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(regs))
return PTR_ERR(regs);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code
2019-09-29 8:32 [PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code Joakim Zhang
@ 2019-09-30 5:53 ` Sean Nyekjaer
2019-10-04 21:10 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Sean Nyekjaer @ 2019-09-30 5:53 UTC (permalink / raw)
To: Joakim Zhang, mkl, linux-can; +Cc: wg, netdev, dl-linux-imx
On 29/09/2019 10.32, Joakim Zhang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together to simplify
> the code.
>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Reviewed-by: Sean Nyekjaer <sean@geanix.com>
> ---
> drivers/net/can/flexcan.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index b3edaf6a5a61..3cfa6037f03c 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -1507,7 +1507,6 @@ static int flexcan_probe(struct platform_device *pdev)
> struct net_device *dev;
> struct flexcan_priv *priv;
> struct regulator *reg_xceiver;
> - struct resource *mem;
> struct clk *clk_ipg = NULL, *clk_per = NULL;
> struct flexcan_regs __iomem *regs;
> int err, irq;
> @@ -1538,12 +1537,11 @@ static int flexcan_probe(struct platform_device *pdev)
> clock_freq = clk_get_rate(clk_per);
> }
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> irq = platform_get_irq(pdev, 0);
> if (irq <= 0)
> return -ENODEV;
>
> - regs = devm_ioremap_resource(&pdev->dev, mem);
> + regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(regs))
> return PTR_ERR(regs);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code
2019-09-29 8:32 [PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code Joakim Zhang
2019-09-30 5:53 ` Sean Nyekjaer
@ 2019-10-04 21:10 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2019-10-04 21:10 UTC (permalink / raw)
To: Joakim Zhang, linux-can; +Cc: wg, netdev, sean, dl-linux-imx
[-- Attachment #1.1: Type: text/plain, Size: 584 bytes --]
On 9/29/19 10:32 AM, Joakim Zhang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together to simplify
> the code.
>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Applied to linux-can-next.
tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-04 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-29 8:32 [PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code Joakim Zhang
2019-09-30 5:53 ` Sean Nyekjaer
2019-10-04 21:10 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).