* [PATCH] net: iosm: remove the repeated declaration and comment
@ 2021-06-16 7:25 Shaokun Zhang
2021-06-16 7:51 ` Kumar, M Chetan
0 siblings, 1 reply; 2+ messages in thread
From: Shaokun Zhang @ 2021-06-16 7:25 UTC (permalink / raw)
To: netdev
Cc: Shaokun Zhang, M Chetan Kumar, Intel Corporation,
David S . Miller, Jakub Kicinski
Function 'ipc_mmio_get_cp_version' is declared twice, so remove the
repeated declaration and wrong comments.
Cc: M Chetan Kumar <m.chetan.kumar@intel.com>
Cc: Intel Corporation <linuxwwan@intel.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
drivers/net/wwan/iosm/iosm_ipc_mmio.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/net/wwan/iosm/iosm_ipc_mmio.h b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
index bcf77aea06e7..45e6923da78f 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
+++ b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
@@ -121,16 +121,6 @@ void ipc_mmio_set_contex_info_addr(struct iosm_mmio *ipc_mmio,
phys_addr_t addr);
/**
- * ipc_mmio_get_cp_version - Write context info and AP memory range addresses.
- * This needs to be called when CP is in
- * IPC_MEM_DEVICE_IPC_INIT state
- * @ipc_mmio: Pointer to mmio instance
- *
- * Returns: cp version else failure value on error
- */
-int ipc_mmio_get_cp_version(struct iosm_mmio *ipc_mmio);
-
-/**
* ipc_mmio_get_cp_version - Get the CP IPC version
* @ipc_mmio: Pointer to mmio instance
*
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] net: iosm: remove the repeated declaration and comment
2021-06-16 7:25 [PATCH] net: iosm: remove the repeated declaration and comment Shaokun Zhang
@ 2021-06-16 7:51 ` Kumar, M Chetan
0 siblings, 0 replies; 2+ messages in thread
From: Kumar, M Chetan @ 2021-06-16 7:51 UTC (permalink / raw)
To: Shaokun Zhang, netdev; +Cc: linuxwwan, David S . Miller, Jakub Kicinski
> Function 'ipc_mmio_get_cp_version' is declared twice, so remove the
> repeated declaration and wrong comments.
>
> Cc: M Chetan Kumar <m.chetan.kumar@intel.com>
> Cc: Intel Corporation <linuxwwan@intel.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/net/wwan/iosm/iosm_ipc_mmio.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> index bcf77aea06e7..45e6923da78f 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> +++ b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> @@ -121,16 +121,6 @@ void ipc_mmio_set_contex_info_addr(struct
> iosm_mmio *ipc_mmio,
> phys_addr_t addr);
>
> /**
> - * ipc_mmio_get_cp_version - Write context info and AP memory range
> addresses.
> - * This needs to be called when CP is in
> - * IPC_MEM_DEVICE_IPC_INIT state
> - * @ipc_mmio: Pointer to mmio instance
> - *
> - * Returns: cp version else failure value on error
> - */
> -int ipc_mmio_get_cp_version(struct iosm_mmio *ipc_mmio);
> -
> -/**
> * ipc_mmio_get_cp_version - Get the CP IPC version
> * @ipc_mmio: Pointer to mmio instance
> *
> --
> 2.7.4
Thanks,
Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 7:25 [PATCH] net: iosm: remove the repeated declaration and comment Shaokun Zhang
2021-06-16 7:51 ` Kumar, M Chetan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).