From: wenxu <wenxu@ucloud.cn>
To: paulb@mellanox.com
Cc: pablo@netfilter.org, netdev@vger.kernel.org, markb@mellanox.com
Subject: Question about flow table offload in mlx5e
Date: Thu, 21 Nov 2019 15:30:14 +0800 [thread overview]
Message-ID: <2a08a1aa-6aa8-c361-f825-458d234d975f@ucloud.cn> (raw)
In-Reply-To: <20191119.163923.660983355933809356.davem@davemloft.net>
Hi paul,
The flow table offload in the mlx5e is based on TC_SETUP_FT.
It is almost the same as TC_SETUP_BLOCK.
It just set MLX5_TC_FLAG(FT_OFFLOAD) flags and change cls_flower.common.chain_index = FDB_FT_CHAIN;
In following codes line 1380 and 1392
1368 static int mlx5e_rep_setup_ft_cb(enum tc_setup_type type, void *type_data,
1369 void *cb_priv)
1370 {
1371 struct flow_cls_offload *f = type_data;
1372 struct flow_cls_offload cls_flower;
1373 struct mlx5e_priv *priv = cb_priv;
1374 struct mlx5_eswitch *esw;
1375 unsigned long flags;
1376 int err;
1377
1378 flags = MLX5_TC_FLAG(INGRESS) |
1379 MLX5_TC_FLAG(ESW_OFFLOAD) |
1380 MLX5_TC_FLAG(FT_OFFLOAD);
1381 esw = priv->mdev->priv.eswitch;
1382
1383 switch (type) {
1384 case TC_SETUP_CLSFLOWER:
1385 if (!mlx5_eswitch_prios_supported(esw) || f->common.chain_index)
1386 return -EOPNOTSUPP;
1387
1388 /* Re-use tc offload path by moving the ft flow to the
1389 * reserved ft chain.
1390 */
1391 memcpy(&cls_flower, f, sizeof(*f));
1392 cls_flower.common.chain_index = FDB_FT_CHAIN;
1393 err = mlx5e_rep_setup_tc_cls_flower(priv, &cls_flower, flags);
1394 memcpy(&f->stats, &cls_flower.stats, sizeof(f->stats));
I want to add tunnel offload support in the flow table, I add some patches in nf_flow_table_offload.
Also add the indr setup support in the mlx driver. And Now I can flow table offload with decap.
But I meet a problem with the encap. The encap rule can be added in hardware successfully But it can't be offloaded.
But I think the rule I added is correct. If I mask the line 1392. The rule also can be add success and can be offloaded.
So there are some limit for encap operation for FT_OFFLOAD in FDB_FT_CHAIN?
BR
wenxu
next prev parent reply other threads:[~2019-11-21 7:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 7:08 [PATCH net-next] ip_gre: Make none-tun-dst gre tunnel keep tunnel info wenxu
2019-11-20 0:39 ` David Miller
2019-11-21 7:30 ` wenxu [this message]
2019-11-21 7:42 ` Question about flow table offload in mlx5e Paul Blakey
2019-11-21 8:28 ` wenxu
2019-11-21 11:39 ` Paul Blakey
2019-11-21 11:40 ` Paul Blakey
2019-11-21 12:35 ` wenxu
2019-11-21 13:05 ` Paul Blakey
2019-11-21 13:39 ` wenxu
2019-11-22 6:12 ` wenxu
[not found] ` <64285654-bc9a-c76e-5875-dc6e434dc4d4@ucloud.cn>
2019-11-24 8:46 ` Paul Blakey
2019-11-24 11:14 ` wenxu
2019-11-26 8:18 ` wenxu
[not found] ` <84874b42-c525-2149-539d-e7510d15f6a6@mellanox.com>
2019-11-27 12:16 ` wenxu
2019-11-27 12:16 ` wenxu
2019-11-27 13:11 ` Paul Blakey
2019-11-27 13:20 ` Paul Blakey
2019-11-27 13:45 ` wenxu
2019-12-02 3:37 ` wenxu
2019-12-05 15:17 ` Paul Blakey
2019-12-08 9:39 ` Paul Blakey
2019-12-09 3:18 ` wenxu
2019-12-09 7:48 ` Paul Blakey
2019-12-09 10:48 ` wenxu
2019-12-10 6:53 ` wenxu
2019-11-28 5:03 ` Bad performance for VF outgoing in offloaded mode wenxu
2019-12-04 13:50 ` Roi Dayan
2019-12-04 14:32 ` wenxu
2019-12-05 3:41 ` wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a08a1aa-6aa8-c361-f825-458d234d975f@ucloud.cn \
--to=wenxu@ucloud.cn \
--cc=markb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paulb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).