From: Paul Blakey <paulb@mellanox.com>
To: wenxu <wenxu@ucloud.cn>
Cc: "pablo@netfilter.org" <pablo@netfilter.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Mark Bloch <markb@mellanox.com>
Subject: RE: Question about flow table offload in mlx5e
Date: Thu, 21 Nov 2019 07:42:46 +0000 [thread overview]
Message-ID: <AM4PR05MB3411591D31D7B22EE96BC6C3CF4E0@AM4PR05MB3411.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <2a08a1aa-6aa8-c361-f825-458d234d975f@ucloud.cn>
Hi,
The original design was the block setup to use TC_SETUP_FT type, and the tc event type to be case TC_SETUP_CLSFLOWER.
We will post a patch to change that. I would advise to wait till we fix that 😊
I'm not sure how you get to this function mlx5e_rep_setup_ft_cb() if it the nf_flow_table_offload ndo_setup_tc event was TC_SETUP_BLOCK, and not TC_SETUP_FT.
In our driver en_rep.c we have:
>-------switch (type) {
>-------case TC_SETUP_BLOCK:
>------->-------return flow_block_cb_setup_simple(type_data,
>------->------->------->------->------->------- &mlx5e_rep_block_tc_cb_list,
>------->------->------->------->------->------- mlx5e_rep_setup_tc_cb,
>------->------->------->------->------->------- priv, priv, true);
>-------case TC_SETUP_FT:
>------->-------return flow_block_cb_setup_simple(type_data,
>------->------->------->------->------->------- &mlx5e_rep_block_ft_cb_list,
>------->------->------->------->------->------- mlx5e_rep_setup_ft_cb,
>------->------->------->------->------->------- priv, priv, true);
>-------default:
>------->-------return -EOPNOTSUPP;
>-------}
In nf_flow_table_offload.c:
>-------bo.binder_type>-= FLOW_BLOCK_BINDER_TYPE_CLSACT_INGRESS;
>-------bo.extack>------= &extack;
>-------INIT_LIST_HEAD(&bo.cb_list);
>-------err = dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_BLOCK, &bo);
>-------if (err < 0)
>------->-------return err;
>-------return nf_flow_table_block_setup(flowtable, &bo, cmd);
}
EXPORT_SYMBOL_GPL(nf_flow_table_offload_setup);
So unless you changed that as well, you should have gotten to mlx5e_rep_setup_tc_cb and not mlx5e_rep_setup_tc_ft.
Regarding the encap action, there should be no difference on which chain the rule is on.
> -----Original Message-----
> From: wenxu <wenxu@ucloud.cn>
> Sent: Thursday, November 21, 2019 9:30 AM
> To: Paul Blakey <paulb@mellanox.com>
> Cc: pablo@netfilter.org; netdev@vger.kernel.org; Mark Bloch
> <markb@mellanox.com>
> Subject: Question about flow table offload in mlx5e
>
> Hi paul,
>
> The flow table offload in the mlx5e is based on TC_SETUP_FT.
>
>
> It is almost the same as TC_SETUP_BLOCK.
>
> It just set MLX5_TC_FLAG(FT_OFFLOAD) flags and change
> cls_flower.common.chain_index = FDB_FT_CHAIN;
>
> In following codes line 1380 and 1392
>
> 1368 static int mlx5e_rep_setup_ft_cb(enum tc_setup_type type, void
> *type_data,
> 1369 void *cb_priv)
> 1370 {
> 1371 struct flow_cls_offload *f = type_data;
> 1372 struct flow_cls_offload cls_flower;
> 1373 struct mlx5e_priv *priv = cb_priv;
> 1374 struct mlx5_eswitch *esw;
> 1375 unsigned long flags;
> 1376 int err;
> 1377
> 1378 flags = MLX5_TC_FLAG(INGRESS) |
> 1379 MLX5_TC_FLAG(ESW_OFFLOAD) |
> 1380 MLX5_TC_FLAG(FT_OFFLOAD);
> 1381 esw = priv->mdev->priv.eswitch;
> 1382
> 1383 switch (type) {
> 1384 case TC_SETUP_CLSFLOWER:
> 1385 if (!mlx5_eswitch_prios_supported(esw) || f-
> >common.chain_index)
> 1386 return -EOPNOTSUPP;
> 1387
> 1388 /* Re-use tc offload path by moving the ft flow to the
> 1389 * reserved ft chain.
> 1390 */
> 1391 memcpy(&cls_flower, f, sizeof(*f));
> 1392 cls_flower.common.chain_index = FDB_FT_CHAIN;
> 1393 err = mlx5e_rep_setup_tc_cls_flower(priv, &cls_flower, flags);
> 1394 memcpy(&f->stats, &cls_flower.stats, sizeof(f->stats));
>
>
> I want to add tunnel offload support in the flow table, I add some patches in
> nf_flow_table_offload.
>
> Also add the indr setup support in the mlx driver. And Now I can flow table
> offload with decap.
>
>
> But I meet a problem with the encap. The encap rule can be added in
> hardware successfully But it can't be offloaded.
>
> But I think the rule I added is correct. If I mask the line 1392. The rule also can
> be add success and can be offloaded.
>
> So there are some limit for encap operation for FT_OFFLOAD in
> FDB_FT_CHAIN?
>
>
> BR
>
> wenxu
>
next prev parent reply other threads:[~2019-11-21 7:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 7:08 [PATCH net-next] ip_gre: Make none-tun-dst gre tunnel keep tunnel info wenxu
2019-11-20 0:39 ` David Miller
2019-11-21 7:30 ` Question about flow table offload in mlx5e wenxu
2019-11-21 7:42 ` Paul Blakey [this message]
2019-11-21 8:28 ` wenxu
2019-11-21 11:39 ` Paul Blakey
2019-11-21 11:40 ` Paul Blakey
2019-11-21 12:35 ` wenxu
2019-11-21 13:05 ` Paul Blakey
2019-11-21 13:39 ` wenxu
2019-11-22 6:12 ` wenxu
[not found] ` <64285654-bc9a-c76e-5875-dc6e434dc4d4@ucloud.cn>
2019-11-24 8:46 ` Paul Blakey
2019-11-24 11:14 ` wenxu
2019-11-26 8:18 ` wenxu
[not found] ` <84874b42-c525-2149-539d-e7510d15f6a6@mellanox.com>
2019-11-27 12:16 ` wenxu
2019-11-27 12:16 ` wenxu
2019-11-27 13:11 ` Paul Blakey
2019-11-27 13:20 ` Paul Blakey
2019-11-27 13:45 ` wenxu
2019-12-02 3:37 ` wenxu
2019-12-05 15:17 ` Paul Blakey
2019-12-08 9:39 ` Paul Blakey
2019-12-09 3:18 ` wenxu
2019-12-09 7:48 ` Paul Blakey
2019-12-09 10:48 ` wenxu
2019-12-10 6:53 ` wenxu
2019-11-28 5:03 ` Bad performance for VF outgoing in offloaded mode wenxu
2019-12-04 13:50 ` Roi Dayan
2019-12-04 14:32 ` wenxu
2019-12-05 3:41 ` wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB3411591D31D7B22EE96BC6C3CF4E0@AM4PR05MB3411.eurprd05.prod.outlook.com \
--to=paulb@mellanox.com \
--cc=markb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).