netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] can: j1939: swap addr and pgn in the send example
@ 2020-10-22  8:37 yegorslists
  2020-10-22  8:41 ` Marc Kleine-Budde
  0 siblings, 1 reply; 2+ messages in thread
From: yegorslists @ 2020-10-22  8:37 UTC (permalink / raw)
  To: linux-can; +Cc: mkl, netdev, Yegor Yefremov

From: Yegor Yefremov <yegorslists@googlemail.com>

The address was wrongly assigned to the PGN field and vice versa.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 Documentation/networking/j1939.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst
index be59fcece3bf..faf2eb5c5052 100644
--- a/Documentation/networking/j1939.rst
+++ b/Documentation/networking/j1939.rst
@@ -414,8 +414,8 @@ Send:
 		.can_family = AF_CAN,
 		.can_addr.j1939 = {
 			.name = J1939_NO_NAME;
-			.pgn = 0x30,
-			.addr = 0x12300,
+			.addr = 0x30,
+			.pgn = 0x12300,
 		},
 	};
 
-- 
2.17.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] can: j1939: swap addr and pgn in the send example
  2020-10-22  8:37 [PATCH] can: j1939: swap addr and pgn in the send example yegorslists
@ 2020-10-22  8:41 ` Marc Kleine-Budde
  0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2020-10-22  8:41 UTC (permalink / raw)
  To: yegorslists, linux-can; +Cc: netdev


[-- Attachment #1.1: Type: text/plain, Size: 569 bytes --]

On 10/22/20 10:37 AM, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> The address was wrongly assigned to the PGN field and vice versa.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---

applied to linux-can/testing

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-22  8:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-22  8:37 [PATCH] can: j1939: swap addr and pgn in the send example yegorslists
2020-10-22  8:41 ` Marc Kleine-Budde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).