netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roopa Prabhu <roopa@nvidia.com>
To: Taehee Yoo <ap420073@gmail.com>, <davem@davemloft.net>,
	<kuba@kernel.org>, <netdev@vger.kernel.org>
Cc: <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net] vxlan: fix memleak of fdb
Date: Sat, 1 Aug 2020 10:09:42 -0700	[thread overview]
Message-ID: <2df4a274-c14e-d9fa-3053-a543feb07a4c@nvidia.com> (raw)
In-Reply-To: <20200801070750.7993-1-ap420073@gmail.com>


On 8/1/20 12:07 AM, Taehee Yoo wrote:
> External email: Use caution opening links or attachments
>
>
> When vxlan interface is deleted, all fdbs are deleted by vxlan_flush().
> vxlan_flush() flushes fdbs but it doesn't delete fdb, which contains
> all-zeros-mac because it is deleted by vxlan_uninit().
> But vxlan_uninit() deletes only the fdb, which contains both all-zeros-mac
> and default vni.
> So, the fdb, which contains both all-zeros-mac and non-default vni
> will not be deleted.
>
> Test commands:
>      ip link add vxlan0 type vxlan dstport 4789 external
>      ip link set vxlan0 up
>      bridge fdb add to 00:00:00:00:00:00 dst 172.0.0.1 dev vxlan0 via lo \
>              src_vni 10000 self permanent
>      ip link del vxlan0
>
> kmemleak reports as follows:
> unreferenced object 0xffff9486b25ced88 (size 96):
>    comm "bridge", pid 2151, jiffies 4294701712 (age 35506.901s)
>    hex dump (first 32 bytes):
>      02 00 00 00 ac 00 00 01 40 00 09 b1 86 94 ff ff  ........@.......
>      46 02 00 00 00 00 00 00 a7 03 00 00 12 b5 6a 6b  F.............jk
>    backtrace:
>      [<00000000c10cf651>] vxlan_fdb_append.part.51+0x3c/0xf0 [vxlan]
>      [<000000006b31a8d9>] vxlan_fdb_create+0x184/0x1a0 [vxlan]
>      [<0000000049399045>] vxlan_fdb_update+0x12f/0x220 [vxlan]
>      [<0000000090b1ef00>] vxlan_fdb_add+0x12a/0x1b0 [vxlan]
>      [<0000000056633c2c>] rtnl_fdb_add+0x187/0x270
>      [<00000000dd5dfb6b>] rtnetlink_rcv_msg+0x264/0x490
>      [<00000000fc44dd54>] netlink_rcv_skb+0x4a/0x110
>      [<00000000dff433e7>] netlink_unicast+0x18e/0x250
>      [<00000000b87fb421>] netlink_sendmsg+0x2e9/0x400
>      [<000000002ed55153>] ____sys_sendmsg+0x237/0x260
>      [<00000000faa51c66>] ___sys_sendmsg+0x88/0xd0
>      [<000000006c3982f1>] __sys_sendmsg+0x4e/0x80
>      [<00000000a8f875d2>] do_syscall_64+0x56/0xe0
>      [<000000003610eefa>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
> unreferenced object 0xffff9486b1c40080 (size 128):
>    comm "bridge", pid 2157, jiffies 4294701754 (age 35506.866s)
>    hex dump (first 32 bytes):
>      00 00 00 00 00 00 00 00 f8 dc 42 b2 86 94 ff ff  ..........B.....
>      6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b  kkkkkkkkkkkkkkkk
>    backtrace:
>      [<00000000a2981b60>] vxlan_fdb_create+0x67/0x1a0 [vxlan]
>      [<0000000049399045>] vxlan_fdb_update+0x12f/0x220 [vxlan]
>      [<0000000090b1ef00>] vxlan_fdb_add+0x12a/0x1b0 [vxlan]
>      [<0000000056633c2c>] rtnl_fdb_add+0x187/0x270
>      [<00000000dd5dfb6b>] rtnetlink_rcv_msg+0x264/0x490
>      [<00000000fc44dd54>] netlink_rcv_skb+0x4a/0x110
>      [<00000000dff433e7>] netlink_unicast+0x18e/0x250
>      [<00000000b87fb421>] netlink_sendmsg+0x2e9/0x400
>      [<000000002ed55153>] ____sys_sendmsg+0x237/0x260
>      [<00000000faa51c66>] ___sys_sendmsg+0x88/0xd0
>      [<000000006c3982f1>] __sys_sendmsg+0x4e/0x80
>      [<00000000a8f875d2>] do_syscall_64+0x56/0xe0
>      [<000000003610eefa>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> Fixes: 3ad7a4b141eb ("vxlan: support fdb and learning in COLLECT_METADATA mode")
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---

Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>


looks right, thanks



  reply	other threads:[~2020-08-01 17:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-01  7:07 [PATCH net] vxlan: fix memleak of fdb Taehee Yoo
2020-08-01 17:09 ` Roopa Prabhu [this message]
2020-08-01 18:50 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2df4a274-c14e-d9fa-3053-a543feb07a4c@nvidia.com \
    --to=roopa@nvidia.com \
    --cc=ap420073@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).