* [PATCH] ixgbevf: delete unneeded call to pci_set_power_state
@ 2014-01-07 17:00 Julia Lawall
2014-01-08 0:16 ` Brown, Aaron F
2014-01-21 20:47 ` Brown, Aaron F
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2014-01-07 17:00 UTC (permalink / raw)
To: Jeff Kirsher
Cc: e1000-devel, kernel-janitors, Bruce Allan, Jesse Brandeburg,
linux-kernel, John Ronciak, netdev
From: Julia Lawall <Julia.Lawall@lip6.fr>
This driver does not need to adjust the power state on suspend, so the
call to pci_set_power_state in the resume function is a no-op. Drop it, to
make the code more understandable.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index a5d3167..5709fb0 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -3226,7 +3226,6 @@ static int ixgbevf_resume(struct pci_dev *pdev)
struct net_device *netdev = adapter->netdev;
u32 err;
- pci_set_power_state(pdev, PCI_D0);
pci_restore_state(pdev);
/*
* pci_restore_state clears dev->state_saved so call
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] ixgbevf: delete unneeded call to pci_set_power_state
2014-01-07 17:00 [PATCH] ixgbevf: delete unneeded call to pci_set_power_state Julia Lawall
@ 2014-01-08 0:16 ` Brown, Aaron F
2014-01-21 20:47 ` Brown, Aaron F
1 sibling, 0 replies; 3+ messages in thread
From: Brown, Aaron F @ 2014-01-08 0:16 UTC (permalink / raw)
To: Julia Lawall, Kirsher, Jeffrey T, netdev, e1000-devel
Cc: Brandeburg, Jesse, Allan, Bruce W, Wyborny, Carolyn, Skidmore,
Donald C, Rose, Gregory V, Duyck, Alexander H, Ronciak, John
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
> On Behalf Of Julia Lawall
> Sent: Tuesday, January 07, 2014 9:00 AM
> To: Kirsher, Jeffrey T
> Cc: kernel-janitors@vger.kernel.org; Brandeburg, Jesse; Allan, Bruce W;
> Wyborny, Carolyn; Skidmore, Donald C; Rose, Gregory V; Duyck, Alexander H;
> Ronciak, John; e1000-devel@lists.sourceforge.net; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] ixgbevf: delete unneeded call to pci_set_power_state
>
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> This driver does not need to adjust the power state on suspend, so the
> call to pci_set_power_state in the resume function is a no-op. Drop it,
> to make the code more understandable.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index a5d3167..5709fb0 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -3226,7 +3226,6 @@ static int ixgbevf_resume(struct pci_dev *pdev)
> struct net_device *netdev = adapter->netdev;
> u32 err;
>
> - pci_set_power_state(pdev, PCI_D0);
> pci_restore_state(pdev);
> /*
> * pci_restore_state clears dev->state_saved so call
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
Thanks Julia, I have added this patch to our internal queue (covering for Jeff.)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ixgbevf: delete unneeded call to pci_set_power_state
2014-01-07 17:00 [PATCH] ixgbevf: delete unneeded call to pci_set_power_state Julia Lawall
2014-01-08 0:16 ` Brown, Aaron F
@ 2014-01-21 20:47 ` Brown, Aaron F
1 sibling, 0 replies; 3+ messages in thread
From: Brown, Aaron F @ 2014-01-21 20:47 UTC (permalink / raw)
To: Julia.Lawall
Cc: Kirsher, Jeffrey T, Brandeburg, Jesse, Allan, Bruce W, Wyborny,
Carolyn, Skidmore, Donald C, Rose, Gregory V, Duyck, Alexander H,
Ronciak, John, kernel-janitors, e1000-devel, netdev,
linux-kernel
On Tue, 2014-01-07 at 18:00 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> This driver does not need to adjust the power state on suspend, so the
> call to pci_set_power_state in the resume function is a no-op. Drop it, to
> make the code more understandable.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index a5d3167..5709fb0 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -3226,7 +3226,6 @@ static int ixgbevf_resume(struct pci_dev *pdev)
> struct net_device *netdev = adapter->netdev;
> u32 err;
>
> - pci_set_power_state(pdev, PCI_D0);
> pci_restore_state(pdev);
> /*
> * pci_restore_state clears dev->state_saved so call
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-21 20:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-07 17:00 [PATCH] ixgbevf: delete unneeded call to pci_set_power_state Julia Lawall
2014-01-08 0:16 ` Brown, Aaron F
2014-01-21 20:47 ` Brown, Aaron F
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).