netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH bpf-next] bpf: cpumap: remove rcpu pointer from cpu_map_build_skb signature
@ 2020-09-28 11:24 Lorenzo Bianconi
  2020-09-28 21:32 ` Daniel Borkmann
  0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2020-09-28 11:24 UTC (permalink / raw)
  To: bpf; +Cc: netdev, ast, daniel, brouer, lorenzo.bianconi

Get rid of bpf_cpu_map_entry pointer in cpu_map_build_skb routine
signature since it is no longer needed

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 kernel/bpf/cpumap.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c
index 7e1a8ad0c32a..c61a23b564aa 100644
--- a/kernel/bpf/cpumap.c
+++ b/kernel/bpf/cpumap.c
@@ -155,8 +155,7 @@ static void cpu_map_kthread_stop(struct work_struct *work)
 	kthread_stop(rcpu->kthread);
 }
 
-static struct sk_buff *cpu_map_build_skb(struct bpf_cpu_map_entry *rcpu,
-					 struct xdp_frame *xdpf,
+static struct sk_buff *cpu_map_build_skb(struct xdp_frame *xdpf,
 					 struct sk_buff *skb)
 {
 	unsigned int hard_start_headroom;
@@ -365,7 +364,7 @@ static int cpu_map_kthread_run(void *data)
 			struct sk_buff *skb = skbs[i];
 			int ret;
 
-			skb = cpu_map_build_skb(rcpu, xdpf, skb);
+			skb = cpu_map_build_skb(xdpf, skb);
 			if (!skb) {
 				xdp_return_frame(xdpf);
 				continue;
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH bpf-next] bpf: cpumap: remove rcpu pointer from cpu_map_build_skb signature
  2020-09-28 11:24 [PATCH bpf-next] bpf: cpumap: remove rcpu pointer from cpu_map_build_skb signature Lorenzo Bianconi
@ 2020-09-28 21:32 ` Daniel Borkmann
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2020-09-28 21:32 UTC (permalink / raw)
  To: Lorenzo Bianconi, bpf; +Cc: netdev, ast, brouer, lorenzo.bianconi

On 9/28/20 1:24 PM, Lorenzo Bianconi wrote:
> Get rid of bpf_cpu_map_entry pointer in cpu_map_build_skb routine
> signature since it is no longer needed
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-28 21:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 11:24 [PATCH bpf-next] bpf: cpumap: remove rcpu pointer from cpu_map_build_skb signature Lorenzo Bianconi
2020-09-28 21:32 ` Daniel Borkmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).