* [PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
@ 2022-01-26 14:47 Alexander Stein
2022-02-09 3:28 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Stein @ 2022-01-26 14:47 UTC (permalink / raw)
To: Joakim Zhang, David S . Miller, Jakub Kicinski, Rob Herring
Cc: Alexander Stein, netdev, devicetree
These properties are inherited from ethernet-controller.yaml.
This fixes the dt_binding_check warning:
imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
index daa2f79a294f..73616924fa29 100644
--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -121,6 +121,10 @@ properties:
mac-address: true
+ nvmem-cells: true
+
+ nvmem-cell-names: true
+
tx-internal-delay-ps:
enum: [0, 2000]
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
2022-01-26 14:47 [PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties Alexander Stein
@ 2022-02-09 3:28 ` Rob Herring
2022-02-10 11:56 ` (EXT) Re: [PATCH 1/1] dt-bindings: net: fsl, fec: " Alexander Stein
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-02-09 3:28 UTC (permalink / raw)
To: Alexander Stein
Cc: Joakim Zhang, David S . Miller, Jakub Kicinski, netdev, devicetree
On Wed, Jan 26, 2022 at 03:47:48PM +0100, Alexander Stein wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index daa2f79a294f..73616924fa29 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -121,6 +121,10 @@ properties:
>
> mac-address: true
>
> + nvmem-cells: true
Need to define how many.
> +
> + nvmem-cell-names: true
And what the names are.
> +
> tx-internal-delay-ps:
> enum: [0, 2000]
>
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (EXT) Re: [PATCH 1/1] dt-bindings: net: fsl, fec: Add nvmem-cells / nvmem-cell-names properties
2022-02-09 3:28 ` Rob Herring
@ 2022-02-10 11:56 ` Alexander Stein
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2022-02-10 11:56 UTC (permalink / raw)
To: Rob Herring
Cc: Joakim Zhang, David S . Miller, Jakub Kicinski, netdev, devicetree
Hi Rob,
Am Mittwoch, 9. Februar 2022, 04:28:54 CET schrieb Rob Herring:
> On Wed, Jan 26, 2022 at 03:47:48PM +0100, Alexander Stein wrote:
> > These properties are inherited from ethernet-controller.yaml.
> > This fixes the dt_binding_check warning:
> > imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> > 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >
> > Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > b/Documentation/devicetree/bindings/net/fsl,fec.yaml index
> > daa2f79a294f..73616924fa29 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> >
> > @@ -121,6 +121,10 @@ properties:
> > mac-address: true
> >
> > + nvmem-cells: true
>
> Need to define how many.
>
> > +
> > + nvmem-cell-names: true
>
> And what the names are.
Thanks for the feedback. Do I really have to copy the following lines from
Documentation/devicetree/bindings/net/ethernet-controller.yaml to
fsl,fec.yaml?
> nvmem-cells:
> maxItems: 1
>
> description:
> Reference to an nvmem node for the MAC address
>
> nvmem-cell-names:
> const: mac-address
This feels wrong to me. Apparently the settings from ethernet-controller.yaml
take effect, e.g. adding a 2nd entry raises warnings. In the end I followed
the example from Documentation/devicetree/bindings/net/engleder,tsnep.yaml, so
I assumed it's okay going this way.
Best regards,
Alexander
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-10 11:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-26 14:47 [PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties Alexander Stein
2022-02-09 3:28 ` Rob Herring
2022-02-10 11:56 ` (EXT) Re: [PATCH 1/1] dt-bindings: net: fsl, fec: " Alexander Stein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).