* [PATCH net-next] i40e: trivial fixup of comments in i40e_xsk.c
@ 2020-03-16 10:16 Jesper Dangaard Brouer
2020-03-16 10:18 ` Björn Töpel
2020-03-18 17:20 ` [Intel-wired-lan] " Bowers, AndrewX
0 siblings, 2 replies; 3+ messages in thread
From: Jesper Dangaard Brouer @ 2020-03-16 10:16 UTC (permalink / raw)
To: Jesper Dangaard Brouer, netdev
Cc: Björn Töpel, Magnus Karlsson, Jeff Kirsher, intel-wired-lan
The comment above i40e_run_xdp_zc() was clearly copy-pasted from
function i40e_xsk_umem_setup, which is just above.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 0b7d29192b2c..30dfb0d3d185 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -184,8 +184,6 @@ int i40e_xsk_umem_setup(struct i40e_vsi *vsi, struct xdp_umem *umem,
* @rx_ring: Rx ring
* @xdp: xdp_buff used as input to the XDP program
*
- * This function enables or disables a UMEM to a certain ring.
- *
* Returns any of I40E_XDP_{PASS, CONSUMED, TX, REDIR}
**/
static int i40e_run_xdp_zc(struct i40e_ring *rx_ring, struct xdp_buff *xdp)
@@ -474,7 +472,7 @@ void i40e_zca_free(struct zero_copy_allocator *alloc, unsigned long handle)
}
/**
- * i40e_construct_skb_zc - Create skbufff from zero-copy Rx buffer
+ * i40e_construct_skb_zc - Create skbuff from zero-copy Rx buffer
* @rx_ring: Rx ring
* @bi: Rx buffer
* @xdp: xdp_buff
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] i40e: trivial fixup of comments in i40e_xsk.c
2020-03-16 10:16 [PATCH net-next] i40e: trivial fixup of comments in i40e_xsk.c Jesper Dangaard Brouer
@ 2020-03-16 10:18 ` Björn Töpel
2020-03-18 17:20 ` [Intel-wired-lan] " Bowers, AndrewX
1 sibling, 0 replies; 3+ messages in thread
From: Björn Töpel @ 2020-03-16 10:18 UTC (permalink / raw)
To: Jesper Dangaard Brouer, netdev
Cc: Magnus Karlsson, Jeff Kirsher, intel-wired-lan
On 2020-03-16 11:16, Jesper Dangaard Brouer wrote:
> The comment above i40e_run_xdp_zc() was clearly copy-pasted from
> function i40e_xsk_umem_setup, which is just above.
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Thanks!
Acked-by: Björn Töpel <bjorn.topel@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 0b7d29192b2c..30dfb0d3d185 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -184,8 +184,6 @@ int i40e_xsk_umem_setup(struct i40e_vsi *vsi, struct xdp_umem *umem,
> * @rx_ring: Rx ring
> * @xdp: xdp_buff used as input to the XDP program
> *
> - * This function enables or disables a UMEM to a certain ring.
> - *
> * Returns any of I40E_XDP_{PASS, CONSUMED, TX, REDIR}
> **/
> static int i40e_run_xdp_zc(struct i40e_ring *rx_ring, struct xdp_buff *xdp)
> @@ -474,7 +472,7 @@ void i40e_zca_free(struct zero_copy_allocator *alloc, unsigned long handle)
> }
>
> /**
> - * i40e_construct_skb_zc - Create skbufff from zero-copy Rx buffer
> + * i40e_construct_skb_zc - Create skbuff from zero-copy Rx buffer
> * @rx_ring: Rx ring
> * @bi: Rx buffer
> * @xdp: xdp_buff
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [Intel-wired-lan] [PATCH net-next] i40e: trivial fixup of comments in i40e_xsk.c
2020-03-16 10:16 [PATCH net-next] i40e: trivial fixup of comments in i40e_xsk.c Jesper Dangaard Brouer
2020-03-16 10:18 ` Björn Töpel
@ 2020-03-18 17:20 ` Bowers, AndrewX
1 sibling, 0 replies; 3+ messages in thread
From: Bowers, AndrewX @ 2020-03-18 17:20 UTC (permalink / raw)
To: netdev; +Cc: intel-wired-lan
>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Jesper Dangaard Brouer
>Sent: Monday, March 16, 2020 3:17 AM
>To: Jesper Dangaard Brouer <brouer@redhat.com>; netdev@vger.kernel.org
>Cc: Topel, Bjorn <bjorn.topel@intel.com>; intel-wired-lan@lists.osuosl.org; Karlsson, Magnus <magnus.karlsson@intel.com>
>Subject: [Intel-wired-lan] [PATCH net-next] i40e: trivial fixup of comments in i40e_xsk.c
>
>The comment above i40e_run_xdp_zc() was clearly copy-pasted from function i40e_xsk_umem_setup, which is just above.
>
>Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
>---
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 +---
>1 file changed, 1 insertion(+), 3 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-18 17:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 10:16 [PATCH net-next] i40e: trivial fixup of comments in i40e_xsk.c Jesper Dangaard Brouer
2020-03-16 10:18 ` Björn Töpel
2020-03-18 17:20 ` [Intel-wired-lan] " Bowers, AndrewX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).