* [PATCH v2] net: ll_temac: Use one return statement instead of two
@ 2015-05-11 14:05 Michal Simek
2015-05-11 18:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2015-05-11 14:05 UTC (permalink / raw)
To: netdev
Cc: Sören Brinkmann, monstr, Fabian Frederick, linux-kernel,
David S. Miller, Manuel Schölling, Julia Lawall,
Markus Elfring, Subbaraya Sundeep Bhatta, linux-arm-kernel
Use one return statement instead of two to simplify the code.
Both are returning the same value.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Changes in v2:
- Use the same SoB as sender address - Reported-by: Julia Lawall
drivers/net/ethernet/xilinx/ll_temac_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 062483f334a5..cfb6bdb37fdc 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -688,10 +688,8 @@ static int temac_start_xmit(struct sk_buff *skb, struct net_device *ndev)
cur_p = &lp->tx_bd_v[lp->tx_bd_tail];
if (temac_check_tx_bd_space(lp, num_frag)) {
- if (!netif_queue_stopped(ndev)) {
+ if (!netif_queue_stopped(ndev))
netif_stop_queue(ndev);
- return NETDEV_TX_BUSY;
- }
return NETDEV_TX_BUSY;
}
--
2.3.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: ll_temac: Use one return statement instead of two
2015-05-11 14:05 [PATCH v2] net: ll_temac: Use one return statement instead of two Michal Simek
@ 2015-05-11 18:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-05-11 18:16 UTC (permalink / raw)
To: michal.simek
Cc: netdev, soren.brinkmann, monstr, fabf, linux-kernel,
manuel.schoelling, julia.lawall, elfring,
subbaraya.sundeep.bhatta, linux-arm-kernel
From: Michal Simek <michal.simek@xilinx.com>
Date: Mon, 11 May 2015 16:05:02 +0200
> Use one return statement instead of two to simplify the code.
> Both are returning the same value.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-11 18:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-11 14:05 [PATCH v2] net: ll_temac: Use one return statement instead of two Michal Simek
2015-05-11 18:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).