netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: David Ahern <dsahern@gmail.com>, netdev <netdev@vger.kernel.org>
Subject: Re: VRF and/or cgroups problem on Fedora-30, 5.2.21+ kernel
Date: Mon, 25 Nov 2019 09:35:02 -0800	[thread overview]
Message-ID: <3daeee00-317a-1f82-648e-80ec14cfed22@candelatech.com> (raw)
In-Reply-To: <fb74534d-f5e8-7b9b-b8c0-b6d6e718a275@gmail.com>

On 11/23/19 10:10 AM, David Ahern wrote:
> On 11/22/19 5:23 PM, Ben Greear wrote:
>>>
>>
>> Setting:  ulimit -l 1024
>>
>> 'fixed' the problem.
>>
>> I'd rather waste a bit of memory and not have any of my users hit such
>> an esoteric
>> bug, so I'll set it to at least 1024 going forward.
> 
> agreed.
> 
>>
>> Would large numbers of vrf and/or network devices mean you need more
>> locked memory?
> 
> I have seen this problem way too much, but not taken the time to track
> down all of the locked memory use. A rough estimate is that each 'ip vrf
> exec' uses 1 page (4kB) of locked memory until the command exits. If you
> use that as a rule you would be on the high end. Commands in the same
> cgroup hierarchy should all be using the same program.

I am not sure if it is a coincidence or not, but we saw the problem when
connected with rdesktop more often than we connected with VNC.

>> And surely 'ip' could output a better error than just 'permission
>> denied' for
>> this error case?  Or even something that would show up in dmesg to give
>> a clue?
> 
> That error comes from the bpf syscall:
> 
> bpf(BPF_PROG_LOAD, {prog_type=BPF_PROG_TYPE_CGROUP_SOCK, insn_cnt=6,
> insns=0x7ffc8e5d1e00, license="GPL", log_level=1, log_size=262144,
> log_buf="", kern_version=KERNEL_VERSION(0, 0, 0), prog_flags=0,
> prog_name="", prog_ifindex=0,
> expected_attach_type=BPF_CGROUP_INET_INGRESS, prog_btf_fd=0,
> func_info_rec_size=0, func_info=NULL, func_info_cnt=0,
> line_info_rec_size=0, line_info=NULL, line_info_cnt=0}, 112) = -1 EPERM
> (Operation not permitted)

So, we can change iproute/lib/bpf.c to print a suggestion to increase locked memory
if this returns EPERM?

Thanks,
Ben

> 
> Yes it is odd and unhelpful for a memory limit to cause the failure and
> then return EPERM.
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2019-11-25 17:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23  0:03 VRF and/or cgroups problem on Fedora-30, 5.2.21+ kernel Ben Greear
2019-11-23  0:06 ` David Ahern
2019-11-23  0:14   ` Ben Greear
2019-11-23  0:17     ` David Ahern
2019-11-23  0:23       ` Ben Greear
2019-11-23 18:10         ` David Ahern
2019-11-25 17:35           ` Ben Greear [this message]
2019-11-25 20:53             ` David Ahern
2019-11-26  8:48               ` Toke Høiland-Jørgensen
2019-11-26 17:36               ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3daeee00-317a-1f82-648e-80ec14cfed22@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).