netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: David Ahern <dsahern@gmail.com>,
	Ben Greear <greearb@candelatech.com>,
	netdev <netdev@vger.kernel.org>
Subject: Re: VRF and/or cgroups problem on Fedora-30, 5.2.21+ kernel
Date: Tue, 26 Nov 2019 09:48:37 +0100	[thread overview]
Message-ID: <87lfs3yqe2.fsf@toke.dk> (raw)
In-Reply-To: <b64cb1b5-f9be-27ab-76e8-4fe84b947114@gmail.com>

David Ahern <dsahern@gmail.com> writes:

> On 11/25/19 10:35 AM, Ben Greear wrote:
>>>> And surely 'ip' could output a better error than just 'permission
>>>> denied' for
>>>> this error case?  Or even something that would show up in dmesg to give
>>>> a clue?
>>>
>>> That error comes from the bpf syscall:
>>>
>>> bpf(BPF_PROG_LOAD, {prog_type=BPF_PROG_TYPE_CGROUP_SOCK, insn_cnt=6,
>>> insns=0x7ffc8e5d1e00, license="GPL", log_level=1, log_size=262144,
>>> log_buf="", kern_version=KERNEL_VERSION(0, 0, 0), prog_flags=0,
>>> prog_name="", prog_ifindex=0,
>>> expected_attach_type=BPF_CGROUP_INET_INGRESS, prog_btf_fd=0,
>>> func_info_rec_size=0, func_info=NULL, func_info_cnt=0,
>>> line_info_rec_size=0, line_info=NULL, line_info_cnt=0}, 112) = -1 EPERM
>>> (Operation not permitted)
>> 
>> So, we can change iproute/lib/bpf.c to print a suggestion to increase
>> locked memory
>> if this returns EPERM?
>> 
>
> looks like SYS_ADMIN and locked memory are the -EPERM failures.
>
> I do not see any API that returns user->locked_vm, only per-task
> locked_vm. Knowing that number would help a lot in understanding proper
> system settings.

Yes! Having a way to see the current amount of locked memory is sorely
needed. Absent this, the application basically has to do one of:

- Throw up its hands and tell the user to increase ulimit (not terribly
  user-friendly)
- Just set the limit to infinity (this is what iproute2 does; works, but
  defeats the whole purpose of having a limit in the first place)
- Keep retrying while gradually increasing the limit (inefficient, and
  annoying to have to implement everywhere)

-Toke


  reply	other threads:[~2019-11-26  8:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23  0:03 VRF and/or cgroups problem on Fedora-30, 5.2.21+ kernel Ben Greear
2019-11-23  0:06 ` David Ahern
2019-11-23  0:14   ` Ben Greear
2019-11-23  0:17     ` David Ahern
2019-11-23  0:23       ` Ben Greear
2019-11-23 18:10         ` David Ahern
2019-11-25 17:35           ` Ben Greear
2019-11-25 20:53             ` David Ahern
2019-11-26  8:48               ` Toke Høiland-Jørgensen [this message]
2019-11-26 17:36               ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfs3yqe2.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=greearb@candelatech.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).