From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Davide Caratti <dcaratti@redhat.com>,
Hangbin Liu <liuhangbin@gmail.com>, Jiri Pirko <jiri@resnulli.us>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>
Subject: Re: [PATCH net 2/2] net: sched: also drop dst for the packets toward ingress in act_mirred
Date: Thu, 23 Sep 2021 12:06:36 -0400 [thread overview]
Message-ID: <40b4a814-2687-b299-4253-ac506710e133@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpU+CMLbDGyTQvo3=MwfbPghnb5C0tPLFmrhe_kaYzP6UA@mail.gmail.com>
+CC Shmulik.
Unfortunately we dont have good test cases in tdc to test different
scenarios of this setup (packets being redirected in both directions
once or several times).
cheers,
jamal
On 2021-09-21 11:52 p.m., Cong Wang wrote:
> On Tue, Sep 21, 2021 at 12:02 AM Xin Long <lucien.xin@gmail.com> wrote:
>>
>> On Tue, Sep 21, 2021 at 2:34 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>>
>>> On Mon, Sep 20, 2021 at 7:12 AM Xin Long <lucien.xin@gmail.com> wrote:
>>>>
>>>> Without dropping dst, the packets sent from local mirred/redirected
>>>> to ingress will may still use the old dst. ip_rcv() will drop it as
>>>> the old dst is for output and its .input is dst_discard.
>>>>
>>>> This patch is to fix by also dropping dst for those packets that are
>>>> mirred or redirected to ingress in act_mirred.
>>>
>>> Similar question: what about redirecting from ingress to egress?
>> We can do it IF there's any user case needing it.
>> But for now, The problem I've met occurred in ip_rcv() for the user case.
>
> I think input route is different from output route, so essentially we need
> a reset when changing the direction, but I don't see any bugs so far,
> except this one.
>
> Thanks.
>
prev parent reply other threads:[~2021-09-23 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 10:19 [PATCH net 0/2] net: sched: drop ct and dst for the packets toward ingress in act_mirred Xin Long
2021-09-20 10:19 ` [PATCH net 1/2] net: sched: drop ct for the packets toward ingress only " Xin Long
2021-09-20 18:31 ` Cong Wang
2021-09-21 7:01 ` Xin Long
2021-09-22 3:43 ` Cong Wang
2021-09-22 5:17 ` Xin Long
2021-09-24 23:04 ` mleitner
2021-09-20 10:19 ` [PATCH net 2/2] net: sched: also drop dst for the packets toward ingress " Xin Long
2021-09-20 18:34 ` Cong Wang
2021-09-21 7:01 ` Xin Long
2021-09-22 3:52 ` Cong Wang
2021-09-22 5:29 ` Xin Long
2021-09-23 16:06 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40b4a814-2687-b299-4253-ac506710e133@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).