netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Davide Caratti <dcaratti@redhat.com>,
	Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net 1/2] net: sched: drop ct for the packets toward ingress only in act_mirred
Date: Mon, 20 Sep 2021 11:31:11 -0700	[thread overview]
Message-ID: <CAM_iQpW53DGw5bXNXot4kV3qSHf5wgD33AFU3=zz0b69mJwNkw@mail.gmail.com> (raw)
In-Reply-To: <13c7b29126171310739195264d5e619b62d27f92.1632133123.git.lucien.xin@gmail.com>

On Mon, Sep 20, 2021 at 7:12 AM Xin Long <lucien.xin@gmail.com> wrote:
>
> nf_reset_ct() called in tcf_mirred_act() is supposed to drop ct for
> those packets that are mirred or redirected to only ingress, not
> ingress and egress.

Any reason behind this? I think we at least need to reset it when
redirecting from ingress to egress as well? That is, when changing
directions?

Thanks.

  reply	other threads:[~2021-09-21  2:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 10:19 [PATCH net 0/2] net: sched: drop ct and dst for the packets toward ingress in act_mirred Xin Long
2021-09-20 10:19 ` [PATCH net 1/2] net: sched: drop ct for the packets toward ingress only " Xin Long
2021-09-20 18:31   ` Cong Wang [this message]
2021-09-21  7:01     ` Xin Long
2021-09-22  3:43       ` Cong Wang
2021-09-22  5:17         ` Xin Long
2021-09-24 23:04           ` mleitner
2021-09-20 10:19 ` [PATCH net 2/2] net: sched: also drop dst for the packets toward ingress " Xin Long
2021-09-20 18:34   ` Cong Wang
2021-09-21  7:01     ` Xin Long
2021-09-22  3:52       ` Cong Wang
2021-09-22  5:29         ` Xin Long
2021-09-23 16:06         ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpW53DGw5bXNXot4kV3qSHf5wgD33AFU3=zz0b69mJwNkw@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=kuba@kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).