From: David Ahern <dsahern@gmail.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
David Ahern <dsa@cumulusnetworks.com>
Cc: linux-kernel@vger.kernel.org,
Michael Jeanson <mjeanson@efficios.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] selftests: Add VRF icmp error route lookup test
Date: Thu, 6 Aug 2020 11:00:24 -0600 [thread overview]
Message-ID: <42cb74c8-9391-cf4c-9e57-7a1d464f8706@gmail.com> (raw)
In-Reply-To: <20200729211248.10146-1-mathieu.desnoyers@efficios.com>
On 7/29/20 3:12 PM, Mathieu Desnoyers wrote:
> From: Michael Jeanson <mjeanson@efficios.com>
>
> The objective is to check that the incoming vrf routing table is selected
> to send an ICMP error back to the source when the ttl of a packet reaches 1
> while it is forwarded between different vrfs.
>
> The first test sends a ping with a ttl of 1 from h1 to h2 and parses the
> output of the command to check that a ttl expired error is received.
>
> [This may be flaky, I'm open to suggestions of a more robust approch.]
>
> The second test runs traceroute from h1 to h2 and parses the output to check
> for a hop on r1.
>
> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> Cc: David Ahern <dsa@cumulusnetworks.com>
Update the address to dsahern@kernel.org
> Cc: David S. Miller <davem@davemloft.net>
> Cc: netdev@vger.kernel.org
> ---
> tools/testing/selftests/net/Makefile | 1 +
> .../selftests/net/vrf_icmp_error_route.sh | 461 ++++++++++++++++++
> 2 files changed, 462 insertions(+)
> create mode 100755 tools/testing/selftests/net/vrf_icmp_error_route.sh
>
Test seems fine to me. you copied icmp_redirect.sh which is fine but
please clean up comments and functions not needed for this test.
next prev parent reply other threads:[~2020-08-06 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 21:12 [RFC PATCH 1/3] selftests: Add VRF icmp error route lookup test Mathieu Desnoyers
2020-07-29 21:12 ` [RFC PATCH 2/3] ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table Mathieu Desnoyers
2020-07-29 21:12 ` [RFC PATCH 3/3] ipv6/icmp: " Mathieu Desnoyers
2020-08-06 17:00 ` David Ahern [this message]
2020-08-06 18:51 ` [PATCH] selftests: Add VRF icmp error route lookup test Michael Jeanson
2020-08-11 17:28 ` David Miller
2020-08-11 18:57 ` David Ahern
2020-08-11 19:11 ` Mathieu Desnoyers
2020-08-11 19:14 ` David Ahern
2020-08-11 19:27 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42cb74c8-9391-cf4c-9e57-7a1d464f8706@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mjeanson@efficios.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).