archive mirror
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <>
To: David Ahern <>
Cc: "David S. Miller" <>,
	Michael Jeanson <>,
	David Ahern <>,
	linux-kernel <>,
	netdev <>
Subject: Re: [PATCH] selftests: Add VRF icmp error route lookup test
Date: Tue, 11 Aug 2020 15:11:03 -0400 (EDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

----- On Aug 11, 2020, at 2:57 PM, David Ahern wrote:

> On 8/11/20 11:28 AM, David Miller wrote:
>> From: Michael Jeanson <>
>> Date: Thu,  6 Aug 2020 14:51:21 -0400
>>> The objective is to check that the incoming vrf routing table is selected
>>> to send an ICMP error back to the source when the ttl of a packet reaches 1
>>> while it is forwarded between different vrfs.
>>> The first test sends a ping with a ttl of 1 from h1 to h2 and parses the
>>> output of the command to check that a ttl expired error is received.
>>> [This may be flaky, I'm open to suggestions of a more robust approch.]
>>> The second test runs traceroute from h1 to h2 and parses the output to
>>> check for a hop on r1.
>>> Signed-off-by: Michael Jeanson <>
>> This patch does not apply cleanly to the current net tree.
> It is also out of context since the tests fail on current net and net-next.
> The tests along with the patches that fix the problem should be sent
> together.

One thing I am missing before this series can be considered for upstreaming
is an Acked-by of the 2 fixes for ipv4 and ipv6 from you, as maintainer
of l3mdev, if you think the approach I am taking with those fixes makes sense.



Mathieu Desnoyers
EfficiOS Inc.

  reply	other threads:[~2020-08-11 19:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 21:12 [RFC PATCH 1/3] selftests: Add VRF icmp error route lookup test Mathieu Desnoyers
2020-07-29 21:12 ` [RFC PATCH 2/3] ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table Mathieu Desnoyers
2020-07-29 21:12 ` [RFC PATCH 3/3] ipv6/icmp: " Mathieu Desnoyers
2020-08-06 17:00 ` [RFC PATCH 1/3] selftests: Add VRF icmp error route lookup test David Ahern
2020-08-06 18:51   ` [PATCH] " Michael Jeanson
2020-08-11 17:28     ` David Miller
2020-08-11 18:57       ` David Ahern
2020-08-11 19:11         ` Mathieu Desnoyers [this message]
2020-08-11 19:14           ` David Ahern
2020-08-11 19:27             ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).