From: Joe Perches <joe@perches.com>
To: Alexander Lobakin <alobakin@pm.me>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Ariel Elior <aelior@marvell.com>,
GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] qede: Use %pM format specifier for MAC addresses
Date: Thu, 30 Jul 2020 10:22:43 -0700 [thread overview]
Message-ID: <481224416317f5d690e7e28cd32b77bf06cdcec9.camel@perches.com> (raw)
In-Reply-To: <pXdhhJtDMa8Tr3tB0ugk5KdQcS3D71r1PEgqtPcJ3kBa4P_Yc0xG6HSXW9O1bQB_1FyD4wvS0xiXLiqvUb3OVzDKR9e7lLijB7jf6ZoHfaw=@pm.me>
On Thu, 2020-07-30 at 16:29 +0000, Alexander Lobakin wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Thu, 30 Jul 2020 19:00:57 +0300
>
> > Convert to %pM instead of using custom code.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/net/ethernet/qlogic/qede/qede_main.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Thanks!
>
> Acked-by: Alexander Lobakin <alobakin@pm.me>
>
> > diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
> > index 1aaae3203f5a..4250c17940c0 100644
> > --- a/drivers/net/ethernet/qlogic/qede/qede_main.c
> > +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
> > @@ -144,9 +144,7 @@ static int qede_set_vf_mac(struct net_device *ndev, int vfidx, u8 *mac)
> > {
> > struct qede_dev *edev = netdev_priv(ndev);
> >
> > - DP_VERBOSE(edev, QED_MSG_IOV,
> > - "Setting MAC %02x:%02x:%02x:%02x:%02x:%02x to VF [%d]\n",
> > - mac[0], mac[1], mac[2], mac[3], mac[4], mac[5], vfidx);
> > + DP_VERBOSE(edev, QED_MSG_IOV, "Setting MAC %pM to VF [%d]\n", mac, vfidx);
> >
> > if (!is_valid_ether_addr(mac)) {
> > DP_VERBOSE(edev, QED_MSG_IOV, "MAC address isn't valid\n");
> > --
> > 2.27.0
I would have expected the debugging output to be in the
opposite order with the valid address test first.
Something like:
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 1aaae3203f5a..30bf9aebd5b8 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -144,15 +144,15 @@ static int qede_set_vf_mac(struct net_device *ndev, int vfidx, u8 *mac)
{
struct qede_dev *edev = netdev_priv(ndev);
- DP_VERBOSE(edev, QED_MSG_IOV,
- "Setting MAC %02x:%02x:%02x:%02x:%02x:%02x to VF [%d]\n",
- mac[0], mac[1], mac[2], mac[3], mac[4], mac[5], vfidx);
-
if (!is_valid_ether_addr(mac)) {
- DP_VERBOSE(edev, QED_MSG_IOV, "MAC address isn't valid\n");
+ DP_VERBOSE(edev, QED_MSG_IOV,
+ "Invalid MAC address %pM for VF [%d]\n", mac, vfidx);
return -EINVAL;
}
+ DP_VERBOSE(edev, QED_MSG_IOV, "Setting MAC %pM to VF [%d]\n",
+ mac, vfidx);
+
return edev->ops->iov->set_mac(edev->cdev, mac, vfidx);
}
next prev parent reply other threads:[~2020-07-30 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 16:29 [PATCH v1] qede: Use %pM format specifier for MAC addresses Alexander Lobakin
2020-07-30 17:22 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-30 16:00 Andy Shevchenko
2020-07-31 23:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481224416317f5d690e7e28cd32b77bf06cdcec9.camel@perches.com \
--to=joe@perches.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=alobakin@pm.me \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).