* [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware
@ 2011-03-21 1:52 Philip Prindeville
2011-03-21 3:01 ` Ben Hutchings
0 siblings, 1 reply; 7+ messages in thread
From: Philip Prindeville @ 2011-03-21 1:52 UTC (permalink / raw)
To: Netdev; +Cc: linux-atm-general
The newest FPGA firmware on the Solos processors correctly signals carrier transitions, bitrate, etc.
The driver previously ignored these messages, and the physical state was always ATM_PHY_SIG_UNKNOWN.
Now that the board reports its state, we expose a bug whereby the transition from UNKNOWN to LOST causes us to release all VC's.
We don't delete any VC's, but instead just send an indication of carrier change.
Signed-off-by: Philip A Prindeville <philipp@redfish-solutions.com>
---
--- a/drivers/atm/solos-pci.c 2011-03-20 15:27:40.000000000 -0600
+++ b/drivers/atm/solos-pci.c 2011-03-20 16:32:11.000000000 -0600
@@ -382,8 +382,10 @@ static int process_status(struct solos_c
/* Anything but 'Showtime' is down */
if (strcmp(state_str, "Showtime")) {
atm_dev_signal_change(card->atmdev[port], ATM_PHY_SIG_LOST);
+#if 0
atm_dev_release_vccs(card->atmdev[port]);
+#endif
dev_info(&card->dev->dev, "Port %d: %s\n", port, state_str);
return 0;
}
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware
2011-03-21 1:52 [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware Philip Prindeville
@ 2011-03-21 3:01 ` Ben Hutchings
2011-03-21 4:57 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Ben Hutchings @ 2011-03-21 3:01 UTC (permalink / raw)
To: Philip Prindeville; +Cc: Netdev, linux-atm-general
On Sun, 2011-03-20 at 18:52 -0700, Philip Prindeville wrote:
> The newest FPGA firmware on the Solos processors correctly signals
> carrier transitions, bitrate, etc.
>
> The driver previously ignored these messages, and the physical state
> was always ATM_PHY_SIG_UNKNOWN.
>
> Now that the board reports its state, we expose a bug whereby the
> transition from UNKNOWN to LOST causes us to release all VC's.
>
> We don't delete any VC's, but instead just send an indication of
> carrier change.
>
> Signed-off-by: Philip A Prindeville <philipp@redfish-solutions.com>
> ---
>
> --- a/drivers/atm/solos-pci.c 2011-03-20 15:27:40.000000000 -0600
> +++ b/drivers/atm/solos-pci.c 2011-03-20 16:32:11.000000000 -0600
> @@ -382,8 +382,10 @@ static int process_status(struct solos_c
>
> /* Anything but 'Showtime' is down */
> if (strcmp(state_str, "Showtime")) {
> atm_dev_signal_change(card->atmdev[port], ATM_PHY_SIG_LOST);
> +#if 0
> atm_dev_release_vccs(card->atmdev[port]);
> +#endif
Either remove it or don't. #if 0 is for people without version control.
Ben.
> dev_info(&card->dev->dev, "Port %d: %s\n", port, state_str);
> return 0;
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware
2011-03-21 3:01 ` Ben Hutchings
@ 2011-03-21 4:57 ` David Miller
2011-03-21 5:56 ` Philip Prindeville
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2011-03-21 4:57 UTC (permalink / raw)
To: bhutchings; +Cc: philipp_subx, netdev, linux-atm-general
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 21 Mar 2011 03:01:36 +0000
> On Sun, 2011-03-20 at 18:52 -0700, Philip Prindeville wrote:
>> The newest FPGA firmware on the Solos processors correctly signals
>> carrier transitions, bitrate, etc.
>>
>> The driver previously ignored these messages, and the physical state
>> was always ATM_PHY_SIG_UNKNOWN.
>>
>> Now that the board reports its state, we expose a bug whereby the
>> transition from UNKNOWN to LOST causes us to release all VC's.
>>
>> We don't delete any VC's, but instead just send an indication of
>> carrier change.
>>
>> Signed-off-by: Philip A Prindeville <philipp@redfish-solutions.com>
>> ---
>>
>> --- a/drivers/atm/solos-pci.c 2011-03-20 15:27:40.000000000 -0600
>> +++ b/drivers/atm/solos-pci.c 2011-03-20 16:32:11.000000000 -0600
>> @@ -382,8 +382,10 @@ static int process_status(struct solos_c
>>
>> /* Anything but 'Showtime' is down */
>> if (strcmp(state_str, "Showtime")) {
>> atm_dev_signal_change(card->atmdev[port], ATM_PHY_SIG_LOST);
>> +#if 0
>> atm_dev_release_vccs(card->atmdev[port]);
>> +#endif
>
> Either remove it or don't. #if 0 is for people without version control.
Also, this would seem to break those using the older firmware.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware
2011-03-21 4:57 ` David Miller
@ 2011-03-21 5:56 ` Philip Prindeville
2011-03-21 6:04 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Philip Prindeville @ 2011-03-21 5:56 UTC (permalink / raw)
To: David Miller; +Cc: bhutchings, netdev, linux-atm-general
On 3/20/11 9:57 PM, David Miller wrote:
> From: Ben Hutchings<bhutchings@solarflare.com>
> Date: Mon, 21 Mar 2011 03:01:36 +0000
>
>> On Sun, 2011-03-20 at 18:52 -0700, Philip Prindeville wrote:
>>> The newest FPGA firmware on the Solos processors correctly signals
>>> carrier transitions, bitrate, etc.
>>>
>>> The driver previously ignored these messages, and the physical state
>>> was always ATM_PHY_SIG_UNKNOWN.
>>>
>>> Now that the board reports its state, we expose a bug whereby the
>>> transition from UNKNOWN to LOST causes us to release all VC's.
>>>
>>> We don't delete any VC's, but instead just send an indication of
>>> carrier change.
>>>
>>> Signed-off-by: Philip A Prindeville<philipp@redfish-solutions.com>
>>> ---
>>>
>>> --- a/drivers/atm/solos-pci.c 2011-03-20 15:27:40.000000000 -0600
>>> +++ b/drivers/atm/solos-pci.c 2011-03-20 16:32:11.000000000 -0600
>>> @@ -382,8 +382,10 @@ static int process_status(struct solos_c
>>>
>>> /* Anything but 'Showtime' is down */
>>> if (strcmp(state_str, "Showtime")) {
>>> atm_dev_signal_change(card->atmdev[port], ATM_PHY_SIG_LOST);
>>> +#if 0
>>> atm_dev_release_vccs(card->atmdev[port]);
>>> +#endif
>> Either remove it or don't. #if 0 is for people without version control.
> Also, this would seem to break those using the older firmware.
It's not clear that dropping all VCs abruptly when carrier flapped was ever the right thing to do.
-Philip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware
2011-03-21 5:56 ` Philip Prindeville
@ 2011-03-21 6:04 ` David Miller
2011-03-21 7:25 ` Philip Prindeville
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2011-03-21 6:04 UTC (permalink / raw)
To: philipp_subx; +Cc: bhutchings, netdev, linux-atm-general
From: Philip Prindeville <philipp_subx@redfish-solutions.com>
Date: Sun, 20 Mar 2011 22:56:43 -0700
> It's not clear that dropping all VCs abruptly when carrier flapped was
> ever the right thing to do.
So you've tested your change with the older firmware present?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware
2011-03-21 6:04 ` David Miller
@ 2011-03-21 7:25 ` Philip Prindeville
2011-04-29 23:09 ` [Linux-ATM-General] " David Woodhouse
0 siblings, 1 reply; 7+ messages in thread
From: Philip Prindeville @ 2011-03-21 7:25 UTC (permalink / raw)
To: David Miller; +Cc: bhutchings, netdev, linux-atm-general
On 3/20/11 11:04 PM, David Miller wrote:
> From: Philip Prindeville<philipp_subx@redfish-solutions.com>
> Date: Sun, 20 Mar 2011 22:56:43 -0700
>
>> It's not clear that dropping all VCs abruptly when carrier flapped was
>> ever the right thing to do.
> So you've tested your change with the older firmware present?
I haven't, no: back-revving firmware has been known to brick cards.
I'm waiting to hear back from Guy and Nathan, they have old cards on hand that they can test.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Linux-ATM-General] [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware
2011-03-21 7:25 ` Philip Prindeville
@ 2011-04-29 23:09 ` David Woodhouse
0 siblings, 0 replies; 7+ messages in thread
From: David Woodhouse @ 2011-04-29 23:09 UTC (permalink / raw)
To: Philip Prindeville; +Cc: David Miller, bhutchings, netdev, linux-atm-general
On Mon, 2011-03-21 at 00:25 -0700, Philip Prindeville wrote:
> On 3/20/11 11:04 PM, David Miller wrote:
> > From: Philip Prindeville<philipp_subx@redfish-solutions.com>
> > Date: Sun, 20 Mar 2011 22:56:43 -0700
> >
> >> It's not clear that dropping all VCs abruptly when carrier flapped was
> >> ever the right thing to do.
> > So you've tested your change with the older firmware present?
>
> I haven't, no: back-revving firmware has been known to brick cards.
>
> I'm waiting to hear back from Guy and Nathan, they have old cards on hand that they can test.
I have JTAG on one of mine and can test, but there's no real need in
this case. If you want to simulate the absence of the 'state changed'
notification, just *ignore* it when it does arrive.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-04-29 23:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-21 1:52 [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware Philip Prindeville
2011-03-21 3:01 ` Ben Hutchings
2011-03-21 4:57 ` David Miller
2011-03-21 5:56 ` Philip Prindeville
2011-03-21 6:04 ` David Miller
2011-03-21 7:25 ` Philip Prindeville
2011-04-29 23:09 ` [Linux-ATM-General] " David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).